[Bug 181635] Re: Various fixes in debian dir

[moonbeam]

It might be worthwhile to take a look at the the version of the patch that made it into awn-core-testing.  It was significantly cleaned up, and slightly restructured, over the initial patch.

1) printf was replaced with g_warning which is consistent with awn-core
practices.

2) The coding style was changed to reflect that of the file being
patched.    It should be noted that there does tend to be a certain
level of deviation in coding style with the core itself though it's
_relatively_ consistent.  awn-extras is much less consistent.  I do
apologize for the tabs - my editor does not seem to be doing what I want
it to do.

3) Ack'd on #define.

4) The error message comment is not without merit.  In the unlikely,
though still possible, chance that the name field is not set this error
message will be immediately preceded by a message indicating the desktop
file(s) in question.  But, in theory, it probably would be a bit more
solid if the change was made and I will make a note about getting that
done.

Thanks for the comments.  We do appreciate hearing about these things.

-- 
Various fixes in debian dir
https://bugs.launchpad.net/bugs/181635
You received this bug notification because you are a member of Ubuntu
Sponsors for universe, which is a direct subscriber.