[Bug 126255] Re: FTBFS
Bryce Harrington
bryce at bryceharrington.org
Tue Aug 28 00:48:55 BST 2007
Hi Chris,
In general this looks good, but I have a few questions.
First, I notice this changeset drops the patch system in favor of using
git. Since upstream uses git, and since we currently use bzr only in
situations where launchpad can track the upstream vcs (i.e. svn, cvs),
I'm not certain this is the right approach. Can you explain why you
chose to go this route?
Second, I notice there are a number of Makefile.in and auto* files in
the ubuntu diff, presumably because autogen.sh was run after creating
the git snapshot. In general it seems more standard to include the
autogen.sh'd files in the snapshot, rather than in the ubuntu diff.
This keeps the ubuntu change simpler.
Would you mind making these changes? Then I think this would be good
for upload.
--
FTBFS
https://bugs.launchpad.net/bugs/126255
You received this bug notification because you are a member of Ubuntu
Sponsors for universe, which is a direct subscriber.
More information about the Ubuntu-universe-sponsors
mailing list