[Bug 1473011] Re: [PATCH] Skip network checks on always dispatchable accounts

[Bug Watch Updater]

Launchpad has imported 2 comments from the remote bug at
https://bugs.freedesktop.org/show_bug.cgi?id=91272.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2015-07-08T20:04:57+00:00 Martin Klapetek wrote:

Created attachment 117009
Patch

I'm using telepathy-ofono with its MC account plugin setting the ofono
account up. The ofono account has always_dispatch set to true, however
when autoconnecting on system startup where no network is available, the
account will not connect and wait for network to come up.

While autoconnecting on MC startup, it gets all the way to
"mcd_account_connection_proceed_with_reason" function where it fails the
"mcd_connectivity_monitor_is_online" check in mcd-account-
connection.c:103 for the account which then leads to the account being
stuck in this state:

Presences:
   Automatic: available (2) ""
     Current: offline (1) ""
   Requested: available (2) ""
    Changing: yes

and from the Debug interface:

"mcd", 5, "mcd_account_connection_proceed_with_reason:
ofono/ofono/account0 wants to connect, but we're offline; queuing it up"

...until there's a network connection. Once there is a network,
everything works just fine.

However if I understand the purpose of always_dispatch=true correctly,
it should ignore the network state and just connect.

So here's a simple patch which makes it work as expected. Now I'm not
sure if this patch is correct as I don't know the MC code that well, but
it does fix the issue of always_dispatch=true-account not being
connected when there's no network.

This patch is against version 5.16.3.

Reply at: https://bugs.launchpad.net/ubuntu/+source/telepathy-mission-
control-5/+bug/1473011/comments/0

------------------------------------------------------------------------
On 2015-12-01T15:20:01+00:00 Martin Klapetek wrote:

Ping, can someone possibly have a look at this patch?

Reply at: https://bugs.launchpad.net/ubuntu/+source/telepathy-mission-
control-5/+bug/1473011/comments/8


** Changed in: mission-control-5
       Status: Unknown => Confirmed

** Changed in: mission-control-5
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of
Telepathy, which is subscribed to telepathy-mission-control-5 in Ubuntu.
https://bugs.launchpad.net/bugs/1473011

Title:
  [PATCH] Skip network checks on always dispatchable accounts

To manage notifications about this bug go to:
https://bugs.launchpad.net/mission-control-5/+bug/1473011/+subscriptions