[Bug 296867]

[Simon McVittie]

>  fp_data = g_variant_get_data (fp_variant);
>  fp = otrl_context_find_fingerprint (context, (guchar *) fp_data, 0, NULL);

I'm still considering "use string fingerprints with error-checking" to
be a merge blocker, because I don't think this code is OK for the case
where fp_data has length != 20 bytes. I think
TrustFingerprint("DEADBEEF") should raise InvalidArgument, whereas
TrustFingerprint("12345678 12345678 12345678123456781234578") (with any
whitespace) should work.

If you strongly prefer the binary encoding, I'd be OK with making
TrustFingerprint([a number of bytes other than 20]) an InvalidArgument,
but I think string fingerprints are going to be nicer to deal with.

-- 
You received this bug notification because you are a member of
Telepathy, which is subscribed to empathy in Ubuntu.
https://bugs.launchpad.net/bugs/296867

Title:
  empathy needs to support OTR encryption

To manage notifications about this bug go to:
https://bugs.launchpad.net/empathy/+bug/296867/+subscriptions