[Bug 768974] [NEW] papyon doesn't answer server's pings

[c10ud]

Public bug reported:

together with Luis Francis we found a nasty bug that affects the
current papyon HEAD (read: 0.5.5). In C you would get a nice linker
error, but in python you won't.
The bug consists in the method that handles QNGs from the server being
defined twice, and the 2nd one being the BAD version. So you will
(not!) see the server thinking your client is offline after some time
and silently disconnecting you. But you won't get any notification
about it because your client is like network timed out. Anyway simply
removing the offending method will solve the issue, and you'll see the
usual PNG-QNG flow back.

This is quite a critical bug to me, and if lfrb won't be able to
release a new version of papyon soon i suggest distro packagers to
manually patch the code, it's a tiny diff you can drop once the next
papyon version is out.

greets
Riccardo
__

diff --git a/papyon/msnp/notification.py b/papyon/msnp/notification.py
index 5aee9f3..8aa691f 100644
--- a/papyon/msnp/notification.py
+++ b/papyon/msnp/notification.py
@@ -695,9 +695,6 @@ class NotificationProtocol(BaseProtocol, Timer):
        self.emit("switchboard-invitation-received", session, inviter)

    # --------- Challenge ----------------------------------------------------
-    def _handle_QNG(self, command):
-        pass
-
    def _handle_QRY(self, command):
        pass

** Affects: papyon (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of
Telepathy, which is subscribed to papyon in Ubuntu.
https://bugs.launchpad.net/bugs/768974

Title:
  papyon doesn't answer server's pings