[Bug 191889] Re: [MASTER] [WORKAROUND] "Offline Mode" feature fails to detect proper online state for networks that are managed outside of network manager.

Alexander Sack asac at jwsdot.com
Wed Sep 24 13:52:38 UTC 2008


thanks for your patch. I would like to consider this. Just one comment
for now:

+nm_device_other_update_ppp (NMData *data,
+			    gboolean is_connected)

isnt that a new function which should be declared in some header?

Is it only ppp that causes issues? I think the most failsafe way would
be to say that once we have an interface with an IP, we are "not-
offline". You think you could extend your 0.6 patch accordingly?

Further, we need a similar approach for NM 0.7. The other heuristic we
could use would be to add a new "non-offline" state (MAYBE_OFFLINE),
which is used instead of online if there is any unmanaged device.
Combining this with the IP-is-set heuristic above, could make offline
state more accurate even.

Feel free to ping me in #ubuntu-mozillateam or -devel to get all this
sorted out and landed in intrepid (and hardy for 0.6.6).

Thanks a lot.

-- 
[MASTER] [WORKAROUND] "Offline Mode" feature fails to detect proper online state for networks that are managed outside of network manager.
https://bugs.launchpad.net/bugs/191889
You received this bug notification because you are a member of
Telepathy, which is subscribed to empathy in ubuntu.




More information about the Ubuntu-telepathy mailing list