[Bug 2138389] Re: [needs-packaging] libnvidia-container

[Andreas Glinserer]

My review on the packaging FWIW:

- Missing origin for patch 0002-fix-makefile.patch: https://gitlab.archlinux.org/archlinux/packaging/packages/libnvidia-container/-/blob/a642a3cc488862a8483075ee63f8a8c470860149/fix-makefile.patch you do mention you got it from Arch so a concrete link is nicer
- Copyright:
-- src/nvcgo/vendor/github.com/cilium should be Expat/MIT as opposed to Apache-2.0
-- src/nvcgo/vendor/github.com/sirupsen/logrus should be Expat/MIT as opposed to Apache-2.0
-- src/nvcgo/vendor/github.com/google should be BSD-3-Clause as opposed to Apache-2.0
-- From what I understand, the following can be combined into a single stanza: 
--- Files: nvidia-modprobe/*
--- Files: nvidia-modprobe/common-utils/{common-utils.c, ….}
--- Files: nvidia-modprobe/modprobe-utils/pci-enum.h
--- Files: nvidia-modprobe/modprobe-utils/pci-sysfs.c
- You have a header file installed in /usr/include as well as a pkg-config and a static lib. Shouldn't those go into a separate libnvidia-container1-dev package?

Just to make sure - I assume both installed libs change their version
together so that it's ok to have them in a single package.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2138389

Title:
  [needs-packaging] libnvidia-container

Status in Ubuntu:
  New

Bug description:
  URL: https://github.com/NVIDIA/libnvidia-container
  License: Apache-2.0
  Notes: This repository provides a library and a simple CLI utility to automatically configure GNU/Linux containers leveraging NVIDIA hardware.
  The implementation relies on kernel primitives and is designed to be agnostic of the container runtime.

  I wish to package libnvidia-container for Ubuntu.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2138389/+subscriptions