[Bug 2136046] Re: macutils compiled on x86-64 uses 64 bit integers for 32-bit CRC calculations

[Nick Rosbrook]

Thanks for taking the time to open this bug and provide a patch. I see
that you are also working with Debian on https://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=1123798, and have reviewed some review from the
maintainer there.

In Ubuntu, we would ultimately want to go with Debian's patch, so I will
not duplicate review here.

Also, because we do not currently have any "delta" on top of Debian's
package, when Debian uploads the fixed version, it will automatically
sync to Ubuntu, unless we are passed feature freeze, which is Feb 19.

If it is uploaded in Debian after that, we can manually sync it over as
a bug fix.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2136046

Title:
  macutils compiled on x86-64 uses 64 bit integers for 32-bit CRC
  calculations

Status in macutils package in Ubuntu:
  New
Status in macutils package in Debian:
  New

Bug description:
  Using macunpack from macutils to unpack a CompactPro archive results
  in an error message

       Header CRC mismatch: got 0x79c895e4, need 0xebae4ed4

  However, the CPT file unpacks successfully using CompactPro 1.52 on an
  emulated Macintosh.

  It appears the problem is that macunpack uses (unsigned long) 64-bit
  integers for the computation of the "Zip CRC", but the CRC computation
  of CompactPro only uses 32 bits.

  Patching several unsigned long -> uint32_t values allows macunpack to
  decode the archive.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/macutils/+bug/2136046/+subscriptions