[Bug 2122576] Re: Add support Intel PTL platform and ITMT3.0 policy

[Julian Andres Klode]

short review:

- the impact does not describe the impact on the user - what does it mean if thermald does not "support Intel PTL platform and support ITMT3 policy when it is present"?
- please add `Origin` headers to the patches (I'd add them below the signed-off-by line); see https://dep-team.pages.debian.net/deps/dep3/
- test plan should figure out if we have existing certified hardware with IMT3 that would be affected by this change and test it

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2122576

Title:
  Add support Intel PTL platform and ITMT3.0 policy

Status in OEM Priority Project:
  New
Status in thermald package in Ubuntu:
  New

Bug description:
  [ Impact ]

   * To make thermald to support Intel PTL platform and support ITMT3
  policy when it is present

  [ Test Plan ]

   * On Intel PTL platform with ITMT3.0 policy configured

   * Boot into Ubuntu

   * Stop the default thermald by $ sudo systemctl stop thermald

   * run the thermlad with extra parameter $ sudo thermald --systemd
  --dbus-enable --adaptive --log-level=info

   * check the journalctl log to confirm that thermald apply the policy
  successfully

  1. Make sure to see ITMT3.0 policy defined in the APAT table
  [1754988644][INFO]..apat dump begin..
  [1754988644][INFO]target_id:62 name:18_MB1_Balance participant:\SB.PC00.TCPU domain:9 code:PL1MIN argument:30000
  [1754988644][INFO]target_id:62 name:18_MB1_Balance participant:\SB.PC00.TCPU domain:9 code:PL1MAX argument:130000
  [1754988644][INFO]target_id:62 name:18_MB1_Balance participant:\SB.PC00.TCPU domain:9 code:PL2PowerLimit argument:150000
  [1754988644][INFO]target_id:62 name:18_MB1_Balance participant:\SB.PC00.TCPU domain:9 code:PL1TimeWindow argument:56000
  [1754988644][INFO]target_id:62 name:18_MB1_Balance participant:\SB.IETM domain:14 code:PSVT argument:18_psvt
  [1754988644][INFO]target_id:62 name:18_MB1_Balance participant:\SB.IETM domain:14 code:ITMT3 argument:18_itmt3_mb1_balance

  2. Check that ITMT3 policy is applied
  [1754988649][INFO]set_int3400 ITMT target 18_itmt3_mb1_balance

  [ Where problems could occur ]

   * https://github.com/intel/thermal_daemon/commit/3144beaf22c4ab27fdb75696bae878668ce02ac8
     If ITMT3 target present in the BIOS, system will go for ITMT policy instead of the default passive policy setup.

   *
  https://github.com/intel/thermal_daemon/commit/03b4a139388f65f093277554ae5e025723320d28
  enhance the support for the ITMT3.0 policy. No code logic change for
  ITMT1.0 and ITMT2.0. For platform within ITMT3.0 configured, might
  change the thermal behavior.

  [ Other Info ]

   * ITMT stands for Intel Turbo Boost Max Technology, a feature that
  identifies the best-performing cores on a processor and directs
  workloads to them for increased single-threaded performance. This
  technology assigns a higher priority to the fastest cores, ensuring
  that demanding tasks get the maximum possible speed on those select
  cores, while other cores handle less intensive work or remain idle.

   * Upstream commits:
     https://github.com/intel/thermal_daemon/commit/3144beaf22c4ab27fdb75696bae878668ce02ac8
     https://github.com/intel/thermal_daemon/commit/03b4a139388f65f093277554ae5e025723320d28

   * extra commit for noble to add PTL support.
     https://github.com/intel/thermal_daemon/commit/be2049afdee8049b3d9deca72c92cc9262c2b1eb
     these two I combine them into one patch
     https://github.com/intel/thermal_daemon/commit/3ea73d5fc4608e83b510f30b70153a299788cbc7
     https://github.com/intel/thermal_daemon/commit/8258cb25b919cfced60904f5ebc313c4b9257659

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/2122576/+subscriptions