[Bug 2127243] Re: [needs-packaging] spirv-reflect

[Sebastien Bacher]

Great work, some small review comments and questions:

* debian/control:
- it's probably not needed to define Vcs-Git/Vcs-Browser if there is no "real" Vcs but just git-ubuntu

- why having a shorted description for the binary than the source?

you could use this for the binary

" ${source:Extended-Description}
 .
 <extra bits to describe the binary>
"

* debian/copyright:

is missing third_party/googletest which are

Copyright: 2005-2025, Google Inc
           2018-2019, Google LLC
License: BSD-3-clause

* debian/rules

would be nice to add a comment explaining why "(cd build && ./test-
spirv-reflect)" is needed for tests

* debian/tests/build

```
# autopkgtest check: Build and run a program against glib, to verify that the
# headers and pkg-config file are installed correctly
# (C) 2012 Canonical Ltd.
```

Leftover from the initial copy I guess?

- could we do better than hardcoding "wd"? Often packages use
$AUTOPKGTEST_TMP / mktemp --tmpdir $AUTOPKGTEST_TMP

* debian/tests/control

The fact that Depends: doesn't include any binary from the package is
weird. Checking "build" you are cloning the repository, are you sure you
are testing against the system version binaries?


The incomplete copyright will be a blocker for the package to pass archive NEW review. The other problems are minor/not blocked though you might want to also ensure the autopkgtests are doing what you expect

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2127243

Title:
   [needs-packaging] spirv-reflect

Status in Ubuntu:
  New

Bug description:
  URL: https://github.com/KhronosGroup/SPIRV-Reflect
  License: Apache-2.0
  Notes: SPIRV-Reflect is a lightweight library that provides a C/C++ reflection API for SPIR-V shader bytecode in Vulkan applications.

  I wish to package spirv-reflect for Ubuntu.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2127243/+subscriptions