[Bug 2089385] Please test proposed package

[Timo Aaltonen]

Hello Manuel, or anyone else affected,

Accepted backport-iwlwifi-dkms into jammy-proposed. The package will
build now and be available at
https://launchpad.net/ubuntu/+source/backport-iwlwifi-
dkms/11510-0ubuntu1~22.04.3 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
jammy to verification-done-jammy. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-jammy. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2089385

Title:
  Fails to build against linux-5.15 after stable update

Status in backport-iwlwifi-dkms package in Ubuntu:
  Invalid
Status in backport-iwlwifi-dkms source package in Jammy:
  Fix Committed
Status in backport-iwlwifi-dkms source package in Noble:
  Fix Committed
Status in backport-iwlwifi-dkms source package in Oracular:
  Fix Released

Bug description:
  [ Impact ]

  Upstream stable update v5.15.170 [1] for jammy introduces a backport
  of upstream commit [2]

  56440d7ec28d genetlink: hold RCU in genlmsg_mcast()

  which drops the @flags parameter from function
  genlmsg_multicast_allns(). The backport-iwlwifi module does not use
  its compat implementation of that function when building against 5.15
  but links against what the kernel is providing. The build will
  consequently fail with:

  <<DKMSDIR>>/build/backport-iwlwifi/11510/build/net/wireless/nl80211.c: In function 'nl80211_common_reg_change_event':
  <<DKMSDIR>>/build/backport-iwlwifi/11510/build/net/wireless/nl80211.c:17769:9: error: too many arguments to function 'genlmsg_multicast_allns'
  17769 |         genlmsg_multicast_allns(&nl80211_fam, msg, 0,
        |         ^~~~~~~~~~~~~~~~~~~~~~~
  In file included from <<DKMSDIR>>/build/backport-iwlwifi/11510/build/backport-include/net/genetlink.h:3,
                   from <<DKMSDIR>>/build/backport-iwlwifi/11510/build/net/wireless/nl80211.c:25:
  ./include/net/genetlink.h:342:5: note: declared here
    342 | int genlmsg_multicast_allns(const struct genl_family *family,
        |     ^~~~~~~~~~~~~~~~~~~~~~~

  In order to build against the kernel with the modified function
  signature of genlmsg_multicast_allns() we need to patch
  net/wireless/nl80211.c that is shipped with backport-iwlwifi and drop
  the now superfluous @flag parameter.

  [ Test Plan ]

  This issue can be reproduced by trying to build the dkms package
  against a 5.15 kernel, e.g. jammy linux, with stable update v5.15.170
  applied.

  [ Where problems could occur ]

  If at some point the compat implementation of the affected
  functionality were to be used instead of what the kernel provides, the
  mismatch between the calls in net/wireless/nl80211.c and the compat
  version of genlmsg_multicast_allns() would cause the build to break
  again.

  [ Other Info ]

  [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2089272
  [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=56440d7ec28d60f8da3bfa09062b3368ff9b16db

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/+bug/2089385/+subscriptions