[Bug 2085524] Re: not starting after upgrading to 24.04

[Simon Quigley]

Hi Dmitriy,

Thank you very much for providing the updated diffs. I have two
remaining points that need to be considered before sponsoring, one is a
blocking concern, the other is easily fixable.

Firstly, the changelog line has this in it (this is the blocking
concern):

+ -- dimas <dimas at work-PC>  Thu, 23 Jan 2025 16:10:46 +0700

Could you please fill this out with your name and email address? For
example, mine would state "Simon Quigley <tsimonq2 at ubuntu.com>"

Secondly, the patch header is a great start, but should be modified to match the DEP-3 format. There are two ways you could proceed here...
 1. Unapply the quilt patch, remove the entire patch *header* (copying the contents somewhere), re-apply the patch, and run `quilt header --dep3 -e`, which will give you a complete DEP-3 header template in a text editor. All you have to do is fill in the details, remove the lines you do not need, save the file in the text editor, and that patch header is automatically replaced.
 2. Alternatively, you can manually align the patch header with the standards laid out in https://dep-team.pages.debian.net/deps/dep3/

To avoid yet another iteration for this fix, if you happen to make a
mistake in your next DEP-3 header, we'll point it out but fix it for
you, no worries. Just try your best. :)

Sorry about the back and forth here. We really appreciate your patience
and persistence here. There are active efforts to document this better,
so we have an easy resource to point you to (thus avoiding some of the
confusion.) Feel free to monitor this page over the coming months:
https://canonical-ubuntu-packaging-guide.readthedocs-
hosted.com/en/latest/

Please resubscribe ubuntu-sponsors when you're ready, or if you have any
questions. We're happy to help.

Thanks,
Simon

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2085524

Title:
  not starting after upgrading to 24.04

Status in krank package in Ubuntu:
  Fix Released
Status in krank source package in Noble:
  Confirmed
Status in krank source package in Oracular:
  Confirmed
Status in krank source package in Plucky:
  Fix Released
Status in krank package in Debian:
  Fix Released

Bug description:
  [ Impact ]

  The game doesn't work.

  All levels in krank are imported as python modules and all game
  screens (menus, settings, actual game stages) are 'levels'. Deprecated
  'imp' is used in Level.py, but in "try - except" statement, so the
  error emerges in other place.

  The solution is to use 'importlib' instead of 'imp'.

  [ Test Plan ]

  Run the game and it will crash after a few moments or not.

  Also in /usr/lib/krank/Main.py you could try to select different levels and try to load them directrly in debug mode
  {{{
  k.debug    = 0
  startlevel = k.debug and 24
  }}}

  [ Where problems could occur ]

  Since the problem is in module that loads all the levels - some levels
  may not load (in debug mode some game logic is missing and it is hard
  to test all of them "the right way").

  [ Other Info ]

  Showing game window for a few seconds and then exits and prints in
  terminal

  {{{
  Traceback (most recent call last):
    File "/usr/lib/krank/Main.py", line 97, in <module>
      k.screen.blit(k.world.image, k.screen.get)rect())
  TypeError: argument 1 must be pygame.surface.Surface, not None
  }}}

  Long story short - it is because "imp" module is deprecated.
  https://docs.python.org/3.9/library/imp.html

  I've created .patch file, but don't know what I shoud do next.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/krank/+bug/2085524/+subscriptions