[Bug 2098878] Re: Deprecated exists? call in ruby >= 3.2.0 causes dependent build failure

[Simon Quigley]

Hey, Julia! Thank you so much for your patches!

I've updated the bug statuses appropriately, I hope that helps!

A few small notes on the patches themselves:
 - Could you please include a reference to this bug report in the changelog? An example of that would be "My example change (LP: #123456)."
 - For the patch header, I think you have the right idea, it just needs another iteration to fully match the DEP-3 format, specifically the timestamp: https://dep-team.pages.debian.net/deps/dep3/
(some of the WIP documentation here may be helpful for you: https://github.com/canonical/ubuntu-packaging-guide/pull/87)
 - The version number seems okay, but no need to target it at -security unless you intend for this to go through the security pocket.
 - It is best practice to follow existing conventions for patch names if doing a non-security upload. In this case, that would involve adding a numbered prefix.

Lastly, the bug description seems like a great start, but could you please consider adding more details? Here are the specific details I'd add:
 - Is this patch fixed upstream anywhere, and if so, do you have a link?
 - I would assume Plucky is not affected, but could you explicitly point that out?
 - I appreciate the details in "Where problems could occur", but is there any downside to using the "exist?" Ruby method here? In my own experience, I often find this to be the most "obviously redundant" section, but it's still important, nonetheless.

Once you have updated patches, please do re-subscribe Ubuntu Sponsors to
this bug, and we'll be happy to give you an updated review. You could
also join #devel:ubuntu.com on Matrix if you have any specific
questions, or want to keep your finger on the pulse when it comes to
Ubuntu Development, so to speak.

I really appreciate your efforts here! This patch is most of the way
there, just some tweaks, and it'll be ready to go!

Best wishes,
Simon

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2098878

Title:
  Deprecated exists? call in ruby >= 3.2.0 causes dependent build
  failure

Status in ruby-blade package in Ubuntu:
  Fix Released
Status in ruby-blade source package in Noble:
  Confirmed
Status in ruby-blade source package in Oracular:
  Confirmed
Status in ruby-blade source package in Plucky:
  Fix Released

Bug description:
  [ Impact ]

   * Starting in ruby 3.2.0, the exists? method was deprecated in favor
     of exist?. As a consequence, the "blade_file_options" method fails.

   * The rails package depends on ruby-blade, and is currently FTBFS
     because of this issue. 

   * This occurs in Noble and Oracular because of their ruby versions.
     The attached debdiff is for oracular.

  [ Test Plan ]

   * Install the patched ruby-blade and attempt to use the 
     blade_file_options method. If the patch was successful the
     method not exist error will no longer occur. 

  [ Where problems could occur ]

   * Problems could occur if this patch were to be applied to releases where
     the corresponding ruby version is less than 3.2.0. 

   * Currently, in ruby >= 3.2.0, blade_file_options fails outright. 
     The risk of regression is low because the method is currently nonfunctional.

  
  [ Other Info ]

   * It's a small change, but blade is an important part of rails' build process.
     We currently cannot build rails from source in either Noble or Oracular without the 
     resolution of this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ruby-blade/+bug/2098878/+subscriptions