[Bug 2127933] Re: Network status shows ethernet connected when no connection is available

[Andreas Hasenack]

I'm sponsoring the noble upload, and skipping plucky because
https://code.launchpad.net/~antoinelassagne/ubuntu/+source/gnome-
shell/+git/gnome-shell/+merge/494697 states they would be skipping
plucky. If plucky is still desired, it's a simple enough sponsor to do
as well, as the branch is ready, and it's the same patch. I left a
comment in the PR to that extent.

** Changed in: gnome-shell (Ubuntu Noble)
       Status: In Progress => Fix Committed

** Tags removed: verification-done
** Tags added: verification-needed verification-needed-noble

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2127933

Title:
  Network status shows ethernet connected when no connection is
  available

Status in GNOME Shell:
  Fix Released
Status in gnome-shell package in Ubuntu:
  Fix Released
Status in gnome-shell source package in Noble:
  Fix Committed
Status in gnome-shell source package in Plucky:
  Won't Fix
Status in gnome-shell source package in Questing:
  Fix Released
Status in gnome-shell source package in Resolute:
  Fix Released

Bug description:
  Per upstream bugs: 
  - https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7357
  - https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/8549

  And it got fixed with https://gitlab.gnome.org/GNOME/gnome-
  shell/-/merge_requests/3910

  ---------------------------
  SRU Justification:

  [ Impact ]

   * The "ethernet connected" symbol is displayed when no network
  connection is available.  If a WiFi connection is available then the
  WiFi symbol is displayed and if an Ethernet connection is available
  then the Ethernet icon is (correctly) displayed but if neither is
  available (WiFi switched off and cable unplugged) then the Ethernet
  icon is still displayed.

   * With the above, the reconnection is fixed.

  [ Fix ]

   * When there is no active main connection or it uses a device type we do not handle, the indicator icon and its visibility depend on the global connectivity.
   
   * However we currently don't update the icon on connectivity changes, with the result that we sometimes show the fallback connection icon when the network is in fact disconnected.

   * To fix this, update the icon whenever the (global) connectivity
  changes.

  [ Test Plan ]

   1. Connect to wifi, see the wifi icon

   2. Disconnect wifi from the menubar, see the ethernet icon pops in

   3. Do it again with the fix: no ethernet icon pops in

   4. Reconnect wifi, see the icon transitioning to connecting ->
  connected.

  [ Where problems could occur ]

   * The _updateIcon is now called more often than before, not less, so
  more frequent icon updates can be expected, but only when they are
  actually relevant thankfully.

To manage notifications about this bug go to:
https://bugs.launchpad.net/gnome-shell/+bug/2127933/+subscriptions