[Bug 2127197] Re: [needs-packaging] vulkancapsviewer

[Vladimir Petko]

Packaging review

MUST:
- Package must meet Ubuntu versioning & Maintainer requirements
  Maintainer should be Maintainer: Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>
  We should not have buildX suffix on upload

- Package must match current Ubuntu (and Debian) packaging policies
Some lintian warnings:
W: vulkancapsviewer source: mismatched-override very-long-line-length-in-source-file 12902 > 512 [libs/vulkan/lib/vulkan-1.lib:5] [debian/source/lintian-overrides:12]
W: vulkancapsviewer source: mismatched-override very-long-line-length-in-source-file 14890 > 512 [libs/vulkan/lib32/vulkan-1.lib:3] [debian/source/lintian-overrides:13]
W: vulkancapsviewer source: mismatched-override very-long-line-length-in-source-file 2198 > 512 [gfx/new_icon.kra:100] [debian/source/lintian-overrides:14]
W: vulkancapsviewer: no-manual-page [usr/bin/vulkanCapsViewer]
I think to make lintian happy we will have to use camelcase manual page for vulkanCapsViewer.

d/control:
Vcs-Browser: https://launchpad.net/ubuntu/+source/vulkancapsviewer
Vcs-Git: https://launchpad.net/ubuntu/+source/vulkancapsviewer
should be pointing to git web interface and git url.

- Package must build, install, run, remove, and purge cleanly
PASS,
 consider fixing build warnings - such as vulkan_profiles.hpp:7396:169: warning: missing initializer for member ‘VkPhysicalDeviceVulkan13Properties::integerDotProduct4x8BitPackedUnsignedAccelerated’ [-Wmissing-field-initializers]
 consider addressing segmentation fault in non-vulkan/non-gui scenario, the capability viewer should display the
 error message and exit.

SHOULD:
- Package should be lintian clean
  FAIL:
  W: vulkancapsviewer source: mismatched-override very-long-line-length-in-source-file 12902 > 512 [libs/vulkan/lib/vulkan-1.lib:5] [debian/source/lintian-overrides:12]
  W: vulkancapsviewer source: mismatched-override very-long-line-length-in-source-file 14890 > 512 [libs/vulkan/lib32/vulkan-1.lib:3] [debian/source/lintian-overrides:13]
  W: vulkancapsviewer source: mismatched-override very-long-line-length-in-source-file 2198 > 512 [gfx/new_icon.kra:100] [debian/source/lintian-overrides:14]
  W: vulkancapsviewer: no-manual-page [usr/bin/vulkanCapsViewer]

- Contents of debian/ should be sane
  d/copyright: is the packaging maintained somewhere at the moment? I am a bit confused by the existing changelog and debian/* copyright. Could you
  please provide more context in https://bugs.launchpad.net/ubuntu/+bug/2127197 ?
  d/copyright: consider replacing debian/patches/0001-patch-remove-CMakeLists.txt-to-use-qmake.patch with exclusion via d/copyright.
  d/copyright: consider excluding gradle wrapper via d/copyright (maybe along the whole android directory)[1]
  d/control: consider updating Description field in line with Debian Policy Manual[2]
  d/control: why do we need qtbase5-dev? libvulkan1 is added by shlib:Deps I think, so we do not need to add it explicitly.
  d/rules: consider adding a separate target to regenerate the man page and update README.Source
  d/vulkancapsviewer-docs.docs: references README.debian that does not exit.
  consider providing icon in /usr/share/applications/vulkanCapsViewer.desktop
- Changelog should close a "needs-packaging" bug
  FAIL, changelog does not reference the bug
- Package should follow http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html
  FAIL, see description guidelines.

Maintenance review
MUST:
- Package must contain a watch file or get-orig-source rule
  PASS
- If upstream is no more, the packager should consider adopting the upstream package somewhere
  N/A
- Packages who implement get-orig-source for packages with watch files get extra points
  No extra points
- Packaged version must not have any known security or critical bugs
  PASS
SHOULD:
- Packaging scripts should be readable and readily comprehensible
  PASS
- Upstream should be responsive, and maintain a bug tracker
  PASS, https://github.com/SaschaWillems/VulkanCapsViewer/issues
- Packaged version should be latest upstream
  FAIL, latest is 4.10
- Package should not be native without an approved spec
  not a native package
Suitability review
MUST:
- Package must meet copyright / licensing requirements
  Pass
- Non-native packages must have verifiable cryptographic path to upstream source
  Upstream does not sign releases
- Package must be advocated by at least two members of ubuntu-dev (the packager may count as one)
  N/A - needs some fixes
SHOULD:
- Package should work on a standard Ubuntu/Kubuntu/Xubuntu/etc. system
  PASS
- Package should provide hints to system services (app-install-data, menus, etc.) to ease installation and use
  PASS, provides desktop file
- Package should provide Ubuntu-specific documentation for variances in behaviour from upstream
  N/A - no difference from upstream
- Package should provide a Homepage: header in debian/control
  PASS

[1] https://wiki.debian.org/UscanEnhancements#Using_uscan_to_strip_files_from_upstream_tarballs
[2] https://www.debian.org/doc/debian-policy/ch-binary.html#the-description-of-a-package

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2127197

Title:
  [needs-packaging] vulkancapsviewer

Status in Ubuntu:
  New

Bug description:
  URL: https://github.com/SaschaWillems/VulkanCapsViewer
  License: LGPL-3
  Notes: Client application to display hardware implementation details for GPUs supporting the Vulkan API by Khronos.

  I wish to package vulkancapsviewer for Ubuntu.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2127197/+subscriptions