[Bug 2127100] Re: [SRU] Fix kernel cmdline for Thor systems, drop incorrect chmod, block jammy do-release-upgrade

[Nick Rosbrook]

@@ -6,8 +6,11 @@ if [ "$1" = configure ] && [ -e /boot/grub/grub.cfg ] && which update-grub >/dev
     update-grub || true
 fi
 
-if [ -e /dev/tpmrm0 ]; then
-    chmod 666 /dev/tpmrm0
+system_compat="$(cat /sys/firmware/devicetree/base/compatible | tr '\0' ' ')"
+
+if [[ "$system_compat" =~ "tegra234" ]]; then
+    # on Orin hardware, disable do-release-upgrade
+    sed -e "s/^Prompt\s*=\(normal\|lts\).*/#Orin is blocked by lack of support by nvidia drivers yet\nPrompt=never/" -i /etc/update-manager/release-upgrades


I am going to re-iterate Chris's second point from comment #18. The ubuntu-release-upgrader code itself is where decisions like this are implemented, see e.g. https://git.launchpad.net/ubuntu-release-upgrader/tree/DistUpgrade/DistUpgradeQuirks.py?h=ubuntu/noble#n2003.

Rejecting based on this.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2127100

Title:
  [SRU] Fix kernel cmdline for Thor systems, drop incorrect chmod, block
  jammy do-release-upgrade

Status in nvidia-tegra-defaults package in Ubuntu:
  Fix Released
Status in nvidia-tegra-defaults source package in Jammy:
  Incomplete
Status in nvidia-tegra-defaults source package in Noble:
  Fix Committed
Status in nvidia-tegra-defaults source package in Plucky:
  Fix Committed
Status in nvidia-tegra-defaults source package in Questing:
  Fix Committed

Bug description:
  [ Impact ]

   * The new Thor platform require an additional kernel command line
  parameter to properly function. The nvidia-tegra-defaults is already
  responsible for some specific kernel cmdline setup, adding these here
  will enable this new hardware.

   * While implementing these fixes, we realized a chmod was pushed
  previously in postinst that shouldn't be there.

  [ Test Plan ]

   * Booting a Thor platform without this patch is not possible if there
  is not another workaround implemented. Booting the board with a noble
  image including this package without any manual change of the kernel
  command line must work.

  [ Where problems could occur ]

   * Thor platforms could still not work if these kernel parameters are
  not enough.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nvidia-tegra-defaults/+bug/2127100/+subscriptions