[Bug 2087852] Re: [FFe][SRU] Repository profiles only act on .list files and do not affect .source files

[Andreas Hasenack]

Ok, we will leave the rejected package alone then, and wait for a new
upload for jammy.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2087852

Title:
  [FFe][SRU] Repository profiles only act on .list files and do not
  affect .source files

Status in Landscape Client:
  Fix Released
Status in landscape-client package in Ubuntu:
  Fix Released
Status in landscape-client source package in Focal:
  Won't Fix
Status in landscape-client source package in Jammy:
  Fix Committed
Status in landscape-client source package in Noble:
  Fix Committed
Status in landscape-client source package in Oracular:
  Won't Fix
Status in landscape-client source package in Plucky:
  Fix Committed

Bug description:
  [Impact]

    * Currently, as reported above, Landscape repository profiles only
  act upon .list files while .sources remain in effect. As Noble
  transitioned from the default source definition being the traditional
  .list files to DEB822 .sources files, this bug manifested when a
  customer noticed sources that they wanted disabled were still
  appearing in apt update.

    * The determined solution was to add pattern matching for .sources
  extensions as well as .list files. Merged PR here:
  https://github.com/canonical/landscape-client/pull/298

    * The first LTS to support DEB822 .sources was Xenial, however, the
  first LTS where this format became the default was noble. The proposed
  SRU is to bring this change back to Focal

    * additionally, .sources and .list files do not get restored when
  repository profiles are unapplied. This was discovered during
  verification of the first proposed fix for this bug.

  [Testing]

    * To reproduce the problem, apply a repository profile on an
  affected ubuntu system and observe that it does not migrate .sources
  files to .sources.save by listing /etc/apt/sources.list.d/, and
  running apt update to see that the sources are still being used

    * Upgrade to the landscape-client packages from proposed and apply a
  Landscape profile, noting that .sources files successfully move to
  .sources.save and no longer appear in the output of apt update

    * Ensure that .list files are also renamed to .list.save (as this is
  the current behaviour)

  The above steps succeeded during verification for proposed versions
  23.02-0ubuntu1~22.04.5 (jammy), 24.02-0ubuntu5.4 (noble), and
  24.08-0ubuntu2.2 (oracular). These additional steps failed, and should
  be tested with any new proposed versions:

    * following the above steps, unapply the Landscape repository
  profile and ensure that .sources.save and .list.save files are renamed
  back to .sources and .list, respectively

  [What can go wrong]

    * The change is rather localized and brief, so it is not expected to
  introduce any regressions or problems. Applying a profile may take
  more time due to extra pattern matching and checking - particularly is
  the filesystem has many .sources files

    * .sources or .list files might be moved and fail to get restored.
  This can result in the ubuntu archive sources no longer being
  considered by apt, or a system that has no active sources or
  sourceparts.

  [Original Description]

  Somewhat related to LP:2062561, landscape-client currently only
  appends .save to source lists ending in .list, which leaves 822 style
  lists using the .sources extension intact.

  This means that applying a repository profile to any machine using the
  new .sources files will still have their public repository sources
  enabled after a repository profile is applied.

  https://github.com/canonical/landscape-
  client/blob/main/landscape/client/manager/aptsources.py#L144

  This was reported 2024-11-08 internally, and now also reported by a
  customer in case:00400550

To manage notifications about this bug go to:
https://bugs.launchpad.net/landscape-client/+bug/2087852/+subscriptions