[Bug 2080004] Re: Shotwell bug - Out of memory #5123

[Nathan Teodosio]

** Description changed:

  Impact
  ------
  
  A memory leak that will cause Shotwell process to increasingly eat
  memory constantly during a slideshow.
  
  Test case
  ---------
  
  *Start Shotwell and import a folder with about 10 photos; End Shotwell.
  
- *Save this script as tester.sh:
+ *Save this script and execute it:
  
  --->
  #!/bin/sh
  shotwell &
  pid=$!
  statm=/proc/$pid/statm
  time=0
  inc=1
+ version=$(dpkg-query -f '${Version}' -W shotwell)
  
  while test -e "$statm"; do
+     #https://www.kernel.org/doc/html/latest/filesystems/proc.html
      stack=$(cut -f6 -d' ' "$statm")
      printf "%s %s\n" "$time" "$stack"
      sleep "$inc"
      time=$((time+inc))
- done >> "$pid.dat"
+ done > "$version.dat"
  <---
- 
- *Execute it.
  
  *Press F5 to start slideshow and keep pressing right arrow to cycle
  through the photo set about 3 times.
  
  *End Shotwell.
  
- Expected: The memory logged in the PID.dat file stops increasing instead
+ Expected: The memory logged in the *.dat file stops increasing instead
  of steadily and indefinidetely increasing.
  
- You can use "xmgrace *.dat" to get a plot of the behavior before and
- after the fix for easier visualization (see attached shotwell-stat.png).
+ You can use "xmgrace -legend load *.dat" to get a plot of the behavior
+ before and after the fix for easier visualization (see attached
+ shotwell-stat.png).
  
+ Regression potential
+ --------------------
+ 
+ The changes are on a function that causes the Pixbuf cache to be
+ regenerated and the UI updated, so it should suffice to observe that
+ images are loaded alright in the slide show.
  
  Further information
  -------------------
  
  Bug upstream: https://gitlab.gnome.org/GNOME/shotwell/-/issues/5123
  
  Fix upstream:
  https://gitlab.gnome.org/GNOME/shotwell/-/commit/fa6884f73af83ccbc72b8fe0f7bc63a00630ee0b

** No longer affects: shotwell (Ubuntu Noble)

** No longer affects: shotwell (Ubuntu Focal)

** No longer affects: shotwell (Ubuntu Jammy)

** Also affects: shotwell (Ubuntu Noble)
   Importance: Undecided
       Status: New

** Changed in: shotwell (Ubuntu Noble)
   Importance: Undecided => High

** Changed in: shotwell (Ubuntu Noble)
     Assignee: (unassigned) => Nathan Teodosio (nteodosio)

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2080004

Title:
  Shotwell bug - Out of memory #5123

Status in Shotwell:
  Fix Released
Status in shotwell package in Ubuntu:
  In Progress
Status in shotwell source package in Noble:
  New

Bug description:
  Impact
  ------

  A memory leak that will cause Shotwell process to increasingly eat
  memory constantly during a slideshow.

  Test case
  ---------

  *Start Shotwell and import a folder with about 10 photos; End
  Shotwell.

  *Save this script and execute it:

  --->
  #!/bin/sh
  shotwell &
  pid=$!
  statm=/proc/$pid/statm
  time=0
  inc=1
  version=$(dpkg-query -f '${Version}' -W shotwell)

  while test -e "$statm"; do
      #https://www.kernel.org/doc/html/latest/filesystems/proc.html
      stack=$(cut -f6 -d' ' "$statm")
      printf "%s %s\n" "$time" "$stack"
      sleep "$inc"
      time=$((time+inc))
  done > "$version.dat"
  <---

  *Press F5 to start slideshow and keep pressing right arrow to cycle
  through the photo set about 3 times.

  *End Shotwell.

  Expected: The memory logged in the *.dat file stops increasing instead
  of steadily and indefinidetely increasing.

  You can use "xmgrace -legend load *.dat" to get a plot of the behavior
  before and after the fix for easier visualization (see attached
  shotwell-stat.png).

  Regression potential
  --------------------

  The changes are on a function that causes the Pixbuf cache to be
  regenerated and the UI updated, so it should suffice to observe that
  images are loaded alright in the slide show.

  Further information
  -------------------

  Bug upstream: https://gitlab.gnome.org/GNOME/shotwell/-/issues/5123

  Fix upstream:
  https://gitlab.gnome.org/GNOME/shotwell/-/commit/fa6884f73af83ccbc72b8fe0f7bc63a00630ee0b

To manage notifications about this bug go to:
https://bugs.launchpad.net/shotwell/+bug/2080004/+subscriptions