[Bug 1965563] Re: GNOME apps crash with "Protocol error" in NVIDIA Wayland sessions

[Robie Basak]

SRU review:

1) debian/patches/egl-wayland-retrieve-DRM-device-name-before-
acquiring-.patch is being modified for no good reason (at least, it
isn't documented) and the dep3 headers are being dropped. Please explain
or fix.

2) Not essential, but the expected package version string would be
1:1.1.9-1.1ubuntu0.1. What you have provided will work but is not our
convention. If re-uploading to fix the above, please use that
opportunity to fix, but it's not necessary to re-upload just for this.

The fix itself looks fine, but I have one query on testing:

> A possible regression would be that the driver starts reporting as
incompatible on NVIDIA single-GPU systems too. One would notice by all
wayland-native applications suddenly being very slow. Note that such
systems would not default to Wayland in Jammy.

Please add to the Test Plan to verify this scenario. In general I'm
concerned about regressing non-NVIDIA systems:

>  * The scope of the change is limited to the NVIDIA proprietary
drivers.

How can we be sure that this is the case? For example, does this package
have limited scope? Is the code being changed protected from affecting
non-NVIDIA systems somehow?

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1965563

Title:
  GNOME apps crash with "Protocol error" in NVIDIA Wayland sessions

Status in NVIDIA / egl-wayland:
  Fix Released
Status in GTK+:
  Fix Released
Status in egl-wayland package in Ubuntu:
  Fix Released
Status in egl-wayland source package in Jammy:
  In Progress

Bug description:
  [ Impact ]

   * GTK applications fail to start on a hybrid graphics machine with an
  NVIDIA discrete GPU.

   * The NVIDIA egl-wayland extension 1.1.9 only supports rendering to
  the NVIDIA GPU if it is the primary GPU. On a hybrid system the
  primary GPU would be the integrated graphics, while the NVIDIA GPU
  should only be used for offloading of specific applications. On such a
  setup, the egl-wayland extension still incorrectly advertised the
  driver as compatible and attempted to use the NVIDIA GPU for all EGL
  applications.

   * To fix the issue, backport a commit from a newer version of the
  NVIDIA egl-wayland extension that reports the driver as incompatible
  when the NVIDIA GPU is not the primary GPU. This effectively ensures
  that all EGL applications run on integrated graphics by default.

  [ Test Plan ]

   * Set up a hybrid graphics machine with Jammy 22.04 LTS and the
  proprietary NVIDIA drivers 535 or 550.

   * Install `libnvidia-egl-wayland1` from the update.

   * Log-in to a Wayland desktop session.

   * Verify that you can start `gnome-text-editor`.

  [ Where problems could occur ]

   * The scope of the change is limited to the NVIDIA proprietary
  drivers.

   * A possible regression would be that the driver starts reporting as
  incompatible on NVIDIA single-GPU systems too. One would notice by all
  wayland-native applications suddenly being very slow. Note that such
  systems would not default to Wayland in Jammy.

  [ Original Report ]

  $ dpkg-query -W gnome-shell-extension-prefs
  gnome-shell-extension-prefs	42~beta-1ubuntu3
  $ gnome-extensions-app
  Gdk-Message: 17:54:19.697: Error reading events from display: Protocol error

  Caveat: I currently have a mix of packages from jammy-release and
  jammy-proposed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/egl-wayland/+bug/1965563/+subscriptions