[Bug 2078327] Re: [needs-packaging] vision-drivers

[Christian Ehrhardt ]

Timo sponsored and asked for a New queue review:

# Managing the package namespace
  src:vision-drivers
  bin:intel-vision-dkms
  Not too short and following the usual model for intel drivers that is already used.
=> OK

- Ensuring compliance with the software license
  - The project itself is GPLv2 of Intel - that seems correct.
    Development history suggests that is 2023-2024 instead of just 2024
  - Yet the packaging you created in debian/* should be GPLv3
    That is the default of Canonical contributions, 
    While there is a policy that Canonical makes contributions
    to upstream projects under the same license that the project
    uses; Debian packaging is not a “contribution to an upstream
    project”.  debian/patches is an exception.
    Due to that debian/* should please be:
      Copyright: 2024, Canonical Ltd                                                   
      License: GPL-3.0
=> Please fix this


# Ensuring correct component based on license
Should be ok to go to universe just like many similar PKGs.
=> universe/kernel


# basic packaging check
- after some initial wondering I can see why upstreams version
  "WW33.3_ARL_Vision_Post_Beta" does not work well. I'm personally ok
   with the git revision. I wondered if something that at least includes "33.3"
   would have been better. But then I do not know much about the project and
   that might bit us soon, while your approach is a bit indirect but works well.
  It misses a debian/watch file and hence is easier to forget to update
  I understand that due to the choice of the version this would always
  say there is a mismatch :-/
  But maybe at least provide a debian/README.source telling all others how
  to correctly detect and re-package the archive on the update?
  Eventually I'm fine with it as-is because at least they all (ipu-drivers,
  ivsc-drivers) follow the same model and you demonstrate on the
  others that you can keep them updated - thanks"

- Standards could be 4.7.0, it is new why not start up to date?
  Not a blocker though, but nice if fixed up on the next upload
 
- VCS- entries ought to be pointing at the package maintenance
  So instead of
  https://github.com/intel/vision-drivers.git 
  It should point at
  https://code.launchpad.net/~vicamo/ubuntu/+source/vision-drivers/+git/vision-drivers
  And furthermore, could it there be under a team and not a personal space?

This isn't a deep check, but it had no red flags on a quick pass
=> OK

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2078327

Title:
  [needs-packaging] vision-drivers

Status in Ubuntu:
  Fix Committed

Bug description:
  Description: Intel Vision Driver on CVS-enabled Platforms
   This package provides kernel drivers for Intel Computer Vision System (CVS)
   on Intel Lunar Lake or later platforms.

  Upstream URL: https://github.com/intel/vision-drivers
  Package source repo: https://code.launchpad.net/~vicamo/ubuntu/+source/vision-drivers/+git/vision-drivers (to request usd-import after created)
  License: GPLv2-only

  PPA: https://launchpad.net/~vicamo/+archive/ubuntu/sru

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2078327/+subscriptions