[Bug 2074212] Re: [SRU] Enable frame-pointer on Noble in libdmapsharing

[Paride Legovini]

That versions string probably works, but I believe we want something
like:

  3.9.13-2ubuntu1~22.04.1

which is not at work of being ambiguous.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2074212

Title:
  [SRU] Enable frame-pointer on Noble in libdmapsharing

Status in libdmapsharing package in Ubuntu:
  Fix Released
Status in libdmapsharing source package in Noble:
  New

Bug description:
  [ Impact ]

  In order to help developers with profiling, Ubuntu enabled frame-
  pointers for packages in the main archive.

  https://ubuntu.com/blog/ubuntu-performance-engineering-with-frame-
  pointers-by-default

  The `Affects` packages were missed due to the packaging issues. These
  have been fixed on Oracular and can now be ported to Noble.

  [Proposed fix]

  Previously, tests run via dh_auto_test were failing and the error
  ignored. See https://launchpadlibrarian.net/722365230/buildlog_ubuntu-
  noble-amd64.libdmapsharing_3.9.13-2build1_BUILDING.txt.gz for the log
  of the build of the package currently in noble.

  Running the test suite was calling `make check`, rebuilding the
  binaries with specific CFLAGS and replacing the ones previously built
  with proper CLFAGS. These binaries were then packaged into the deb.

  Not running the tests was found to be the best solution until upstream
  maintainers fix the way test binaries are built.

  [ Test Plan ]

  Look at the DW_AT_producer in the associated debug ELF file for flags.
  -fno-omit-frame-pointer should be present after the fix.

  The following scripts can be used as a reference
  https://gist.github.com/julian-klode/85e55553f85c410a1b856a93dce77208
  https://gist.github.com/julian-klode/95818246eaef0ac6a54588f7f368e25c

  -fno-omit-frame-pointer is also present in build logs and now binaries
  are not rebuilt without this flag anymore to run tests.

  Smoke test I ran:

  Download https://www2.cs.uic.edu/~i101/SoundFiles/StarWars3.wav (or
  any wav file)

  sudo apt install rhythmbox
  sudo dpkg -i libdmapsharing-4.0-3t64_3.9.13-2ubuntu1_amd64.deb

  
  I was unable to find a daap server in the archive (I even tried to configure rhythmbox/xmms2/vlc to do it, without any luck) so I had to use owntone in a container. A simpler solution may exist though.

  mkdir -p scratch/owntone/{etc,media,cache}
  cp StarWars3.wav scratch/owntone/media/
  docker run -d \
    --name=OwnTone \
    --network=host \
    -e UID=$(id -u) \
    -e GID=$(id -g) \
    -v $HOME/scratch/owntone/etc:/etc/owntone \
    -v $HOME/scratch/owntone/media:/srv/media \
    -v $HOME/scratch/owntone/cache:/var/cache/owntone \
    --restart unless-stopped \
    docker.io/owntone/owntone:latest

  At this point owntone is sharing the wav file over DAAP.
  Launch rhythmbox.
  An entry in the `Shared` section of the left menu should be visible. StarWars3.wav should be playable.

  
  [ Where problems could occur ]

  No source changes are made. The packaging fixes have enabled other
  security hardening flags. This could have unintended effects.

  [ Other Info ]

  Changes in dpkg have been made to make sure frame-pointers are not
  enabled on s390x and ppc64el.

  Bug reference with similar SRU
  - https://bugs.launchpad.net/ubuntu/+source/ipvsadm/+bug/2071949

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libdmapsharing/+bug/2074212/+subscriptions