[Bug 2077382] Re: [SRU] support additional parametes on deploy()

[Lukas Märdian]

The cherry-picked distro patch matches upstream changes. Thank you for
providing proper DEP-3 headers and a PPA test build!

LGTM, sponsored.

PS: I'm unsubscribing ~ubuntu-sponsors, as @mfo will handle the SRU
uploads.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2077382

Title:
  [SRU] support additional parametes on deploy()

Status in python-libmaas package in Ubuntu:
  In Progress
Status in python-libmaas source package in Jammy:
  In Progress
Status in python-libmaas source package in Noble:
  In Progress
Status in python-libmaas source package in Oracular:
  In Progress
Status in python-libmaas source package in Plucky:
  In Progress

Bug description:
  [ Impact ]

  * This SRU is not addressing an existing problem but adds support for
  two additional optional parameters being ephemeral_deploy and
  enable_hw_sync on deploy(). For more details please see (1).

  
  [ Test Plan ]

  * Pre-Requisits: A MAAS controller, an API key as well as a free
  physical machine or VM to perform the deployment tests.

  * Install the current version of python3-libmaas
  (0.6.8-0ubuntu0.22.04.1), then perform a deployment. Validate the
  final results, including the final machine state of Deployed and any
  other tests such as SSH. Release the machine after he validation is
  complete.

  * Install the modified python3-libmaas (0.6.8-0ubuntu0.22.04.2), then
  perform a new deployment. Verify the deployment results, similar to
  the previous step. Release the machine after completion. This step
  ensures there are no regressions as the newly introduced parameters
  are set to False by default.

  * Repeat the deployment while still on modified version. This time
  supply the new additional parameters ephemeral_deploy=True,
  enable_hw_sync=True. Verify the final results and release the machine.
  Please note that since this is an ephemeral deployment, it completes
  very quickly.

  * To help streamlining the test process, a test script has been
  provided and attached to the bug. It requires maas_endpoint as well as
  maas_apikey variables to be filled in the source before being
  utilized. Please note that install_python_libmaas_modified() currently
  installs the modified package from a temporary PPA - That would
  require a modification to install the modified package from the
  proposed pocket and similar.

  * To manually validate an Ephemeral deployment, SSH to the deployed
  machine and issue the following command, while comparing the output
  (Note overlayroot):

  $ mount | grep -w /
  overlayroot on / type overlay (rw,relatime,lowerdir=/media/root-ro,upperdir=/media/root-rw/overlay,workdir=/media/root-rw/overlay-workdir/_,xino=off)

  * To manually validate the presence of Hardware Sync, issue the
  following command. Note "Finished MAAS Hardware Sync Service" message
  line in the output.

  $ sudo systemctl status maas_hardware_sync

  
  [ Where problems could occur ]

  * Due to the nature of the change and the additional parameters being
  optional we are not expecting any adverse effect on existing
  integration using python-libmaas.

  (1) https://github.com/canonical/python-libmaas/issues/300

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-libmaas/+bug/2077382/+subscriptions