[Bug 2054390] Re: Refine proc mounts entries traversal

[Benjamin Drung]

Unsubscribing ~ubuntu-sponsors for now. Please re-subscribe once ready.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2054390

Title:
  Refine proc mounts entries traversal

Status in cryptsetup package in Ubuntu:
  Incomplete
Status in cryptsetup source package in Focal:
  In Progress
Status in cryptsetup source package in Jammy:
  In Progress
Status in cryptsetup source package in Mantic:
  In Progress
Status in cryptsetup source package in Noble:
  Incomplete

Bug description:
  [Impact]
  When LDAP automount maps generate a substantial number of entries in /proc/mounts, it has the potential to induce a timeout issue, particularly during the process of iterating through the entries twice in the cryptroot hook.

  [Fix]
  Utilizing awk to initially filter out pertinent mount points results in a notable reduction in the execution time of the hook.

  [Test Plan]
  The patch maintains the existing logic within the hook.
  Our primary objective is to ensure that the output remains consistent when obtaining devnos through iteration.
  1. Execute the /usr/share/initramfs-tools/hooks/cryptroot binary
  2. Confirm that the output does not include the following warning message:
  cryptsetup: WARNING: Couldn't determine root device

  [Where problems could occur]
  The patch exclusively modifies the method of extracting information without altering the underlying hook logic.
  It's crucial to note that the successful generation of the crypttab is contingent upon the accuracy of the information provided by the patch.
  Any inaccuracies may impede the crypttab generation process.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+subscriptions