[Bug 2054391] Re: Fix CPU thermal sensors enumeration

[Christian Ehrhardt ]

This all LGTM, sponsoring to jammy-unapproved

$ dput ubuntu ../thermald_2.4.9-1ubuntu0.5_source.changes
Uploading thermald using ftp to ubuntu (host: upload.ubuntu.com; directory: /ubuntu)
running gitubuntu: Warn if uploading without git-ubuntu Vcs-* entries.
running updatemaintainer: Stop if ubuntu changes are without ubuntu maintainer.
running gpg: check GnuPG signatures before the upload
running suite-mismatch: check the target distribution for common errors
running ppaforppaonly: Stop uploads to the archive with or to ppa without ~ppa suffix.
running nobug: Stop if uploading without any bug reference.
running releasemismatch: Warn about mismatching suffixesg e.g. focal with a XX.YY not being 20.04
running placeholderbug: Stop if using common placeholder numbers as bug reference.
running supported-distribution: check whether the target distribution is currently supported (using distro-info)
{'allowed': ['release', 'proposed', 'backports', 'security'], 'known': ['release', 'proposed', 'updates', 'backports', 'security']}
running check-debs: makes sure the upload contains a binary package
running required-fields: check whether a field is present and non-empty in the changes file
running checksum: verify checksums before uploading
running badauthor: Stop if uploading with root@ or ubuntu@ email adresses.
Uploading thermald_2.4.9-1ubuntu0.5.dsc
Uploading thermald_2.4.9-1ubuntu0.5.debian.tar.xz
Uploading thermald_2.4.9-1ubuntu0.5_source.buildinfo
Uploading thermald_2.4.9-1ubuntu0.5_source.changes

Up to the SRU team to have a second look and then probably to you
@kaihengfeng to test it on a system of the right size for verification.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2054391

Title:
  Fix  CPU thermal sensors enumeration

Status in HWE Next:
  New
Status in thermald package in Ubuntu:
  Fix Released
Status in thermald source package in Jammy:
  Confirmed

Bug description:
  [Impact]
  Some CPU sensors are not enumerated, this can make thermald deviates from the correct behavior of the CPU TDP.

  [Fix]
  Traverse all sensors under hwmon sysfs directory to make sure everything is enumerated.

  [Test]
  Check the output of thermald. Once the fix is in place, thermal zones that are previously omitted now shows up:
  [INFO]Zone 1: AMBF, Active:1 Bind:1 Sensor_cnt:1
  To do so
  0. get a large machine which will have more thermal zones
  1. stop the potentially auto-running service
     $ systemctl stop thermald
  2. run the daemon in foreground with loglevel to see what is going on.
     On many modern systemd (=the large ones) it might not know the CPUid,
     to bypass that for the test you can ask it to ignore the check
     $ sudo thermald --no-daemon --loglevel=info --ignore-cpuid-check
  3. check the output
     On init the system will be probed and that will show something like:

  ...
   ZONE DUMP BEGIN
  [1718954645][INFO]Zone 2: cpu, Active:1 Bind:0 Sensor_cnt:1
  ...
  [1718954645][INFO]Zone 3: cpu, Active:1 Bind:0 Sensor_cnt:1
  ...
   ZONE DUMP END

  In here, on systems with many thermal zones one would before the fix
  only see a few, and with the fix more zones.


  [Where problems could occur]
  Since the new logic traverse the whole hwmon sysfs, the startup time can take slightly longer.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hwe-next/+bug/2054391/+subscriptions