[Bug 2060848] Re: [SRU] minifycss fails to run

[Paride Legovini]

This LGTM, I just have a nit. For noble you prepared this d/changelog
entry:

matthiasmullie-minify (1.3.68-4ubuntu0.24.04.1) noble; urgency=medium

while for Mantic:

matthiasmullie-minify (1.3.68-4ubuntu0.1) mantic; urgency=medium

Can you please make them consistent (always ubuntu0.XX.YY.n)?

Thanks!

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2060848

Title:
  [SRU] minifycss fails to run

Status in matthiasmullie-minify package in Ubuntu:
  Fix Released
Status in matthiasmullie-minify source package in Mantic:
  Confirmed
Status in matthiasmullie-minify source package in Noble:
  Confirmed
Status in matthiasmullie-minify package in Debian:
  Fix Released

Bug description:
  [ Impact ]

  minifycss and minifyjs is completely unusable and will fail
  immediately on execution with the error:

  $ minifycss
  PHP Warning:  require_once(/usr/bin/../src/Minify.php): Failed to open stream: No such file or directory in /usr/bin/minifycss on line 10
  PHP Fatal error:  Uncaught Error: Failed opening required '/usr/bin/../src/Minify.php' (include_path='.:/usr/share/php') in /usr/bin/minifycss:10
  Stack trace:
  #0 {main}
    thrown in /usr/bin/minifycss on line 10

  
  $ minifyjs 
  PHP Warning:  require_once(/usr/bin/../src/Minify.php): Failed to open stream: No such file or directory in /usr/bin/minifyjs on line 10
  PHP Fatal error:  Uncaught Error: Failed opening required '/usr/bin/../src/Minify.php' (include_path='.:/usr/share/php') in /usr/bin/minifyjs:10
  Stack trace:
  #0 {main}
    thrown in /usr/bin/minifyjs on line 10

  
  [ Test Plan ]

  1. install php-matthiasmullie-minify
  2. copy the sample test files from tests folder of the source

  test minifycss:
  minifycss  tests/css/sample/bom/bom.css

  test minifyjs:
  minifyjs  tests/js/sample/bugs/227/original.js

  If the package is not fixed it will result in the above error.
  With the fixed package it will display the minified versions.

  [ Where problems could occur ]

  The fix is including autoload.php which has been autogenerated as part
  of the build and is adding all the required paths. It is not changing
  any part of the code and there should not be any regression due to
  this change.

  
  [ Other Info ]

  Oracular, Noble and Mantic were affected. Oracular now has synced and
  the Debian fix is in it now.

  
  [ Original Bug Description ]

  minifycss fails to run with the error:

  $ minifycss
  PHP Warning:  require_once(/usr/bin/../src/Minify.php): Failed to open stream: No such file or directory in /usr/bin/minifycss on line 10
  PHP Fatal error:  Uncaught Error: Failed opening required '/usr/bin/../src/Minify.php' (include_path='.:/usr/share/php') in /usr/bin/minifycss:10
  Stack trace:
  #0 {main}
    thrown in /usr/bin/minifycss on line 10

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/matthiasmullie-minify/+bug/2060848/+subscriptions