[Bug 2069384] Re: puppetdb fails to build from source on noble

[Nick Rosbrook]

Thanks for finding the minimal patches required for this. A few
organizational things:

1. 0008-Resolve-ftbfs-with-java-21.patch: It would be good to have an
Origin: field in the patch showing where you got this. It's good you
have the Author: for credit, but links are easier to follow. I also
prefer to have Bug-Ubuntu: fields in the patch headers.

2. 0009-Replace-use-of-to-pson.patch: This patch needs dep3 headers in
general.

3. Are both patches, and the d/control change, directly related to the
FTBFS? If so, the changelog would be more readable with an entry like:

* Fix FTBFS on noble (LP: XXXXXXX)
  - first patch summary
  - second patch summary
  - d/control change summary
* [...the rest...]

4. Finally, from a quick glance, it seems these same autopkgtest
failures exist in oracular. Can you prepare a patch to fix those in
oracular too?

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2069384

Title:
  puppetdb fails to build from source on noble

Status in puppetdb package in Ubuntu:
  Fix Released
Status in puppetdb source package in Noble:
  Incomplete

Bug description:
  [ Impact ]
  * Package puppetdb fails to build from source on noble. The `default-jdk/jre` packages from java-common have been migrated to openjdk-21. And the puppetdb level on noble (7.12.1-3) fails to build with openjdk-21. See ppa build [1].

  * The current binaries of puppetdb were built prior to the default-jdk
  migration to openjdk-21. Running them with openjdk-21 (which puppetdb
  does not support) can have unforeseen consequences to users.

  * Users of puppetdb migrating to noble from jammy might see
  regressions.

  [ Test Plan ]
  * Building puppetdb 7.12.1-3 on noble as in [1] causes FTBFS.

  [ Where problems could occur ]

  * This SRU proposes upgrading puppetdb to 8.4.1-1 (which is currently
  uploaded to oracular). This version is compatible with openjdk-21.

  * However, puppetdb 8.4.1-1 also needs libclj-http-clojure (>= 3.12.3)
  which is not satisfiable on noble [2]. I plan to create a parallel SRU
  request, which should precede the current one, for package clj-http-
  clojure too.

  [ Other Info ]
  * I haven't attempted running the 7.12.1-3 binaries with the default-jdk/openjdk-21 because FTBFS in itself is an indicator of incompatibility and needs to be addressed.
  * I also created an SRU bug for clj-http-clojure [3].
  * A successful PPA build of puppetdb 8.4.1-1 on Noble, with libclj-http-clojure updated to 3.12.3-1 is seen here [4].

  [1] https://launchpad.net/~pushkarnk/+archive/ubuntu/puppetdb-sru1/+build/28577254
  [2] https://launchpad.net/~pushkarnk/+archive/ubuntu/puppetdb-sru2/+build/28577255
  [3] https://bugs.launchpad.net/ubuntu/+source/clj-http-clojure/+bug/2069390
  [4] https://launchpad.net/~pushkarnk/+archive/ubuntu/puppetdb-sru3/+build/28577425

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/puppetdb/+bug/2069384/+subscriptions