[Bug 2066983] Re: Bug in /etc/update-motd.d/50-landscape-sysinfo script - incorrect variable used for load threshold calculation

[Dan Bungert]

Hi Spencer, thanks for SRUing this fix.

I have elected to upload to f/j/m/n/o series with the following corrections:
* ubuntu/devel targetted branch needed series updated for oracular, and a
  simple merge
* all the rest needed version number corrections - I suggest having a look at
  https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging
  which outlines the version number scheme and the reasons.  In the case of
  your mantic/noble proposals, those uploads would have been rejected because
  landscape-client version 23.08-0ubuntu2 and 24.02-0ubuntu6 have been uploaded
  previously.  The focal / jammy ones had plausible version numbers but I have
  updated them to more closely match what's suggested on the wiki.
* the format of debian/changelog wants a certain date stamp format (month and
  day were flipped), consider using `dch -i` to add the entry, or `date -R` can
  also help.  `dch` will also help with the version number increment.


** Changed in: landscape-client (Ubuntu)
       Status: In Progress => Fix Committed

** Changed in: landscape-client (Ubuntu)
     Assignee: Spencer Runde (spencerrunde) => (unassigned)

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2066983

Title:
  Bug in /etc/update-motd.d/50-landscape-sysinfo script - incorrect
  variable used for load threshold calculation

Status in landscape-client package in Ubuntu:
  Fix Committed

Bug description:
  [ Impact ]

   * The CPU load is incorrectly calculated, and users won't get system info in
  the message-of-the-day (motd).

   * The `cores` variable was misnamed; it should be `CORES` since bash
  variables are case-sensitive

  * Affects landscape-client on noble, mantic, jammy, and focal.

  [ Test Plan ]

  Steps to Reproduce:

      1. Open the /etc/update-motd.d/50-landscape-sysinfo script.
      2. Notice the line where THRESHOLD is set: THRESHOLD="${cores:-1}.0".
      3. The correct variable should be CORES instead of cores.

  To trigger MOTD and view incorrect calculation:

  sudo run-parts /etc/update-motd.d/
  Notice message: " System information disabled due to load higher than 1.0" even on systems with multiple cores.

  [ Where problems could occur ]

   * This fix will necessarily run the system process info on more
  systems during MOTD.  If the CPU load threshold was poorly chosen,
  then overly-loaded systems might be slow during MOTD while landscape-
  sysinfo runs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/landscape-client/+bug/2066983/+subscriptions