[Merge] ~mirespace/ubuntu/+source/openssh:merge-lp2040406-noble into ubuntu/+source/openssh:debian/sid

[Nick Rosbrook]

Review: Needs Fixing

I didn't take this as a unilateral change at all, and I agree the MP is an appropriate place to discuss this! I apologize if my review came across the wrong way.

However, the change still doesn't look quite right to me. Looking at your commits, I see changes to d/rules in 1faaf8b6aa and 46ad7bf628. And, the overall debian/rules diff between your branch and pkg/debian/sid shows that we did not keep Debian's rescue-ssh.target change:

nr at six:/t/t/openssh$ git diff pkg/debian/sid mirespace/merge-lp2040406-noble -- debian/rules
diff --git a/debian/rules b/debian/rules
index c921ece2..6b3b6ea5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -189,9 +189,9 @@ override_dh_installinit:
        dh_installinit -R --name ssh
 
 override_dh_installsystemd:
-       dh_installsystemd -popenssh-server ssh.service
-       dh_installsystemd -popenssh-server --no-enable ssh.socket
-       dh_installsystemd -popenssh-server --no-start rescue-ssh.target
+       dh_installsystemd -popenssh-server --no-start ssh.socket
+       dh_installsystemd -popenssh-server --no-enable --no-start ssh.service
+       dh_installsystemd -popenssh-server rescue-ssh.target
 
 debian/openssh-server.sshd.pam: debian/openssh-server.sshd.pam.in
 ifeq ($(DEB_HOST_ARCH_OS),linux)
-- 
https://code.launchpad.net/~mirespace/ubuntu/+source/openssh/+git/openssh/+merge/459366
Your team Ubuntu Sponsors is requested to review the proposed merge of ~mirespace/ubuntu/+source/openssh:merge-lp2040406-noble into ubuntu/+source/openssh:debian/sid.