[Merge] ~pushkarnk/ubuntu/+source/onionshare:werkzeug-3.0.1-compat into ubuntu/+source/onionshare:ubuntu/devel

[Pushkar Kulkarni]

> Thank you for working on this!
> 

Thanks for the detailed review!

> Same comment about the Origin: dep3 header: I had to do some investigation to
> identify that it's upstream commit 9a19c471 that actually landed upstream,
> though in this case it looks unmodified from the commit provided in the PR. It
> would be helpful to link to this directly from the DEP3 headers (though a link
> to the upstream PR is also helpful!).
>

I've updated the DEP3 header with the commit link.
 
> I can see that you've taken a subset of these changes and that's fine.
> 
> How are you validating that this is sufficient to get onionshare working
> correctly against the newer werkzeug? I see that this is a GUI app. Have you
> tried running it or are you relying on autopkgtests alone? If the latter and
> given the nature of the necessary changes, how are we sure that we haven't
> missed something?

No, I solely depended on the autopkgtests which run the upstream unit tests (I guess all of them, but I'd need some time to confirm that). This changes goes into the cli component and is specific to change in the url API only. So, I didn't consider any further testing, though the thought crossed my mind! 

That brings me to a question: while patching upstream packages is passing the upstream unit/regression test suite considered as a sufficient condition for submitting the patch?
-- 
https://code.launchpad.net/~pushkarnk/ubuntu/+source/onionshare/+git/onionshare/+merge/458934
Your team Ubuntu Sponsors is requested to review the proposed merge of ~pushkarnk/ubuntu/+source/onionshare:werkzeug-3.0.1-compat into ubuntu/+source/onionshare:ubuntu/devel.