[Bug 1875642] Re: [SRU] FSVS - not able to commit changes to remote HTTP SVN repo

[Sudip Mukherjee]

Thanks Dave for the changelog idea. So, another attempt now.

Removed old debdiff and attaching new debdiff for Manctic.

** Patch removed: "fsvs_mantic.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/fsvs/+bug/1875642/+attachment/5741111/+files/fsvs_mantic.debdiff

** Patch removed: "fsvs_jammy.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/fsvs/+bug/1875642/+attachment/5741112/+files/fsvs_jammy.debdiff

** Patch removed: "fsvs_focal.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/fsvs/+bug/1875642/+attachment/5741113/+files/fsvs_focal.debdiff

** Patch added: "fsvs_mantic.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/fsvs/+bug/1875642/+attachment/5741941/+files/fsvs_mantic.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1875642

Title:
  [SRU] FSVS - not able to commit changes to remote HTTP SVN repo

Status in fsvs package in Ubuntu:
  Fix Released
Status in fsvs source package in Focal:
  Confirmed
Status in fsvs source package in Jammy:
  Confirmed
Status in fsvs source package in Lunar:
  Opinion
Status in fsvs source package in Mantic:
  Confirmed

Bug description:
  [ Impact ]

  If the user is using fsvs with SVN via http then fsvs is completely unusable as it will fail to commit to SVN.
  With the affected versions of fsvs, the user will see the following error message when they try to commit:

   An error occurred: The filesystem editor completion process was not followed (160050)
    in ci__work: editor->close_edit: Closing editor with directories or files open

  And, as a result fsvs fails to commit changes to HTTP SVN repo.

  [ Test Plan ]

   * login as root and use the following steps:
     - apt-get install apache2 libapache2-mod-svn fsvs
     - mkdir -p /home/REPO/REPO-svn/svn/
     - cd /home/REPO/REPO-svn/svn/
     - svnadmin create test
     - find /home/REPO -exec chown www-data:www-data {} \;
     - htpasswd -c /home/REPO/REPO-svn/.htpasswd.svn root  (set a password in this step)
     - cat >/etc/apache2/mods-available/svn.conf <<EOF
          <Location /svn/>
                  ### SVN ###
                  DAV svn
                  SVNParentPath /home/REPO/REPO-svn/svn/
                  AuthUserFile /home/REPO/REPO-svn/.htpasswd.svn
                  Require valid-user
                  AuthType Basic
                  AuthName "SVN reposity"

                  AuthBasicProvider file
          </Location>
      EOF
      - ln -s /etc/apache2/mods-available/svn.conf /etc/apache2/mods-enabled/svn.conf
      - systemctl restart apache2.service
      - cd /home/ubuntu/
      - fsvs urls http://localhost/svn/test
      - fsvs
      - fsvs commit -mstart

  [ Where problems could occur ]

   * The upstream patch is closing the root_baton at the end of the
  commit which SVN expects fsvs to do. The root_baton is not used after
  the point where is now being closed so has little chance of regression
  due to this. Also, it does not change any other code and so user
  should not see any change in behaviour.

  [ Other Info ]

   *  The problem exists in versions before v1.2.12 and so Noble is
  fixed. But Focal, Jammy, Lunar and Mantic are still affected.

  [ Original Bug Description ]

  After upgrading one of my machines to Ubuntu 20.04 fsvs stopped
  working. I`m not able to commit changes to remote repo provided by
  libapache2-mod-svn. I`ve tried to reproduce it by installing
  apache2+mod-svn+svn locally and the result is the same.

  SVN client works fine.

  ||/ Name           Version       Architecture Description
  +++-==============-=============-============-============================================
  ii  fsvs           1.2.7-1build2 amd64        Full system versioning with metadata support
  ii  subversion     1.13.0-3     amd64        Advanced version control system

  Fresh SVN repo, fresh fsvs config and fresh apache2+svn install (all on the same box):
  Apache config:
          <Location /svn/>
                  ### SVN ###
                  DAV svn
                  SVNParentPath /home/REPO/REPO-svn/svn/
                  AuthzSVNAccessFile /home/REPO/REPO-svn/.htaccess-svn.svn
                  AuthUserFile /home/REPO/REPO-svn/.htpasswd.svn
                  Require valid-user
                  AuthType Basic
                  AuthName "SVN reposity"

                  AuthBasicProvider file
          </Location>

  Result (quick and dirty):

  root at BOX /home/REPO/REPO-svn/svn # svnadmin create test
  root at BOX /home/REPO/REPO-svn/svn # find /home/REPO -exec chown www-data:www-data {} \;
  root at BOX /home/REPO/REPO-svn/svn # cd /home/bummer
  root at BOX /home/bummer # fsvs urls http://localhost/svn/test
  root at BOX /home/bummer # fsvs
  N...       dir  apcupsd
  N...      2344  apcupsd/multimon.conf
  N...       387  apcupsd/offbattery
  N...     12656  apcupsd/apcupsd.conf
  N...       377  apcupsd/commfailure
  N...      1052  apcupsd/ups-monitor
  N...       352  apcupsd/onbattery
  N...       617  apcupsd/killpower
  N...     13238  apcupsd/apcupsd.conf.dpkg-dist
  N...       416  apcupsd/commok
  N...       662  apcupsd/hosts.conf
  N...      4007  apcupsd/apccontrol
  N...       388  apcupsd/changeme
  .mC.       dir  .
  root at BOX /home/bummer # fsvs commit -mstart
  [... user login here ...]

  Committing to http://localhost/svn/test
  N...       dir  apcupsd
  N...      2344  apcupsd/multimon.conf
  N...       387  apcupsd/offbattery
  N...     12656  apcupsd/apcupsd.conf
  N...       377  apcupsd/commfailure
  N...      1052  apcupsd/ups-monitor
  N...       352  apcupsd/onbattery
  N...       617  apcupsd/killpower
  N...     13238  apcupsd/apcupsd.conf.dpkg-dist
  N...       416  apcupsd/commok
  N...       662  apcupsd/hosts.conf
  N...      4007  apcupsd/apccontrol
  N...       388  apcupsd/changeme

  An error occurred: The filesystem editor completion process was not followed (160050)
    in ci__work: editor->close_edit: Closing editor with directories or files open
  root at BOX /home/bummer #

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/fsvs/+bug/1875642/+subscriptions