[Bug 2049554] Re: Sync cunit 2.1-3-dfsg-2.7 (universe) from Debian unstable (main)

[Graham Inggs]

This bug was fixed in the package cunit - 2.1-3-dfsg-2.7
Sponsored for Sudip Mukherjee (sudipmuk)

---------------
cunit (2.1-3-dfsg-2.7) unstable; urgency=medium

  * Non-maintainer upload.

  [ Mate Kukri ]
  * d/p/curses_ftbfs.patch:
    Fix FTBFS caused by incorrect use of WINDOW. (Closes: #1057930)

  [ Sudip Mukherjee ]
  * Fixed the patch from Mate Kukri.
    - Thanks to Sven Joachim for pointing out getmaxx and getmaxy.

 -- Sudip Mukherjee <sudipm.mukherjee at gmail.com>  Thu, 11 Jan 2024
16:36:37 +0000

** Changed in: cunit (Ubuntu)
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2049554

Title:
  Sync cunit 2.1-3-dfsg-2.7 (universe) from Debian unstable (main)

Status in cunit package in Ubuntu:
  Fix Released

Bug description:
  Please sync cunit 2.1-3-dfsg-2.7 (universe) from Debian unstable
  (main)

  Explanation of the Ubuntu delta and why it can be dropped:
    * d/p/curses_ftbfs.patch:
      Fix FTBFS caused by incorrect use of WINDOW (LP: #2048086)

  Changelog entries since current noble version 2.1-3-dfsg-2.6ubuntu1:

  cunit (2.1-3-dfsg-2.7) unstable; urgency=medium

    * Non-maintainer upload.

    [ Mate Kukri ]
    * d/p/curses_ftbfs.patch:
      Fix FTBFS caused by incorrect use of WINDOW. (Closes: #1057930)

    [ Sudip Mukherjee ]
    * Fixed the patch from Mate Kukri.
      - Thanks to Sven Joachim for pointing out getmaxx and getmaxy.

   -- Sudip Mukherjee <sudipm.mukherjee at gmail.com>  Thu, 11 Jan 2024
  16:36:37 +0000

  
  The same patch from Ubuntu with a modification has been added in Debian.
  The modification has been discussed with Mate on irc and pasting irc log
  here for reference.

  Jan 11 16:10:46 <sudip> mkukri: have you seen the comment at https://bugs.debian.org/1057930 ? Specifically the line saying "Note that getmaxx(win) returns win->_maxx + 1, and similar for getmaxy.". if that is true then your patch will be adding 1 to all x and y.
  Jan 11 16:10:47 -ubottu/#ubuntu-devel-  Debian bug 1057930 in src:cunit "cunit: FTBFS: invalid use of incomplete typedef ‘WINDOW’ {aka ‘struct _win_st’}" [Serious, Open]
  Jan 11 16:12:07 <mkukri>        oh oh
  Jan 11 16:13:41 <sudip> https://sources.debian.org/src/ncurses/6.4+20231209-1/include/curses.h.in/?hl=1203#L1203
  Jan 11 16:15:09 <mkukri>        ah that is rather annoying, i fixed up the same thing in multiple packages, so probably all need fixed
  Jan 11 16:18:33 <mkukri>        sudip: im in a meeting now, but i can prepare updated patches later
  Jan 11 16:18:58 <sudip> mkukri: dont worry about cunit, I will fix it for you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cunit/+bug/2049554/+subscriptions