[Bug 2029314] Re: [SRU] Hexchat crashes whenever I click on a specific link in a channel

[Vladimir Petko]

Thank you very much!!!

I will test the patch and upload it for noble.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2029314

Title:
  [SRU] Hexchat crashes whenever I click on a specific link in a channel

Status in HexChat:
  Fix Released
Status in hexchat package in Ubuntu:
  Confirmed
Status in hexchat source package in Jammy:
  Confirmed
Status in hexchat source package in Mantic:
  Confirmed
Status in hexchat source package in Noble:
  Confirmed

Bug description:
  [ Impact ]

  hexchat will crash when an user clicks on a link in any irc tab if the
  url contains URL Encoded value of the Forward Slash (/). The URL can
  be a valid url like:

  https://github.com/SciQLop/SciQLopPlots/tree/main/.github%2Fworkflows
  or
  https://salsa.debian.org/debian/softhsm2/-/tree/master/src%2Fbin

  There are other example of the URL and all of them will crash hexchat
  even though the URL can be opened on a browser.

  [ Test Plan ]

  Open hexchat
  connect to the ubuntu servers as a guest
  send the url as a message to the guest
  click on the url from the guest's screen.

  hexchat will crash if the package is not fixed.
  With the fixed package, hexchat will not crash but instead it will say "file not found"

  Send a good url like https://salsa.debian.org/ and confirm that
  hexchat can still open it to check there is no regression.

  
  [ Where problems could occur ]

  This is an upstream patch which has modified the way it is testing for
  fobidden characters in the url. So, as a worst case, if the patch is
  buggy then URL clicking ability of hexchat will be affected.

  [ Other Info ]

  upstream patch is further encoding the '%' in the URL to %25 which is the correct thing to do. And thus the URL becomes an invalid url after hexchat processes it.
  As a hexchat user I would have preferred if upstream could have somehow managed to open the URL as we can open it in the browser.

  [ Original Bug Description ]

  The link in question:

  https://github.com/SciQLop/SciQLopPlots/tree/main/.github%2Fworkflows

  Hexchat has persistent history, so I can click this link any time and
  Hexchat will instantly crash. I am not sure if it will be reproducible
  for anyone else. The link itself is not harmful. When clicked, Firefox
  pops to the foreground but does not open the link. Hexchat crashes
  with a segfault inside glib.

  ProblemType: Bug
  DistroRelease: Ubuntu 23.04
  Package: hexchat 2.16.1-1build2
  ProcVersionSignature: Ubuntu 6.2.0-23.23-generic 6.2.12
  Uname: Linux 6.2.0-23-generic x86_64
  NonfreeKernelModules: nvidia_modeset nvidia
  ApportVersion: 2.26.1-0ubuntu2
  Architecture: amd64
  CasperMD5CheckResult: pass
  CurrentDesktop: XFCE
  Date: Wed Aug  2 00:58:01 2023
  InstallationDate: Installed on 2023-06-01 (61 days ago)
  InstallationMedia: Xubuntu 23.04 "Lunar Lobster" - Release amd64 (20230414.2)
  SourcePackage: hexchat
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/hexchat-irc/+bug/2029314/+subscriptions