[Bug 2092078] Re: r8168-dkms FTBS in Noble with linux-6.11-hwe kernel

[Timo Aaltonen]

Hello Massimiliano, or anyone else affected,

Accepted r8168 into noble-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/r8168/8.052.01-1ubuntu1.1 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
noble to verification-done-noble. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-noble. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: r8168 (Ubuntu Noble)
       Status: In Progress => Fix Committed

** Changed in: r8168 (Ubuntu)
       Status: In Progress => Invalid

** Tags added: verification-needed verification-needed-noble

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2092078

Title:
  r8168-dkms FTBS in Noble with linux-6.11-hwe kernel

Status in r8168 package in Ubuntu:
  Invalid
Status in r8168 source package in Noble:
  Fix Committed

Bug description:
  [ Impact ]

  r8168-dkms does not compile from source in Noble with kernel 6.11:

  /var/lib/dkms/r8168/8.052.01/build/r8168_n.c:7978:20: error: initialization of ‘int (*)(struct net_device *, struct ethtool_keee *)’ from incompatible pointer type ‘int (*)(struct net_device *, struct ethtool_eee *)’ [-Werror=incompatible-pointer-types]
   7978 |         .get_eee = rtl_ethtool_get_eee,
        |                    ^~~~~~~~~~~~~~~~~~~
  /var/lib/dkms/r8168/8.052.01/build/r8168_n.c:7978:20: note: (near initialization for ‘rtl8168_ethtool_ops.get_eee’)
  /var/lib/dkms/r8168/8.052.01/build/r8168_n.c:7979:20: error: initialization of ‘int (*)(struct net_device *, struct ethtool_keee *)’ from incompatible pointer type ‘int (*)(struct net_device *, struct ethtool_eee *)’ [-Werror=incompatible-pointer-types]
   7979 |         .set_eee = rtl_ethtool_set_eee,
        |                    ^~~~~~~~~~~~~~~~~~~
  /var/lib/dkms/r8168/8.052.01/build/r8168_n.c:7979:20: note: (near initialization for ‘rtl8168_ethtool_ops.set_eee’)

  [ Test case ]

  Install the latest linux-6.11 kernel on Noble:

  $ sudo add-apt-repository ppa:canonical-kernel-team/ppa
  $ sudo apt update
  $ sudo apt install linux-image-6.11.0-12-generic \
                     linux-modules-6.11.0-12-generic \
                     linux-modules-extra-6.11.0-12-generic \
                     linux-headers-6.11.0-12-generic

  Install r8168-dkms:

  $ sudo apt install r8168-dkms

  Load the module:

  $ sudo modprobe r8168

  The same procedure should be repeated on linux-6.8 to test for
  possible regressions.

  [ Fix ]

  Patch the code to properly support the new linux 6.11 ABI.

  [ Regression potential ]

  A possible regression is possible in systems using r8168-dkms with the
  new 6.11 kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/r8168/+bug/2092078/+subscriptions