[Bug 2086455] Re: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present

[Cody Shepherd]

Hi, I've verified the changes by building a riscv64 image from -proposed
and verified that the image builds successfully. Thanks!

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2086455

Title:
  manifest not generated for ubuntu-cpc uefi hook in riscv64 when no
  subarch present

Status in livecd-rootfs package in Ubuntu:
  New
Status in livecd-rootfs source package in Jammy:
  Fix Committed

Bug description:
  [ Impact ]

   * Lack of manifest causes downstream builds to break during the
  manifest copy commands in the qcow binary hook. This is causing jammy
  riscv64 builds to fail.

   * proposed fix [1] is to check that $SUBARCH is nonzero in the if
  branch that returns early.

  [ Test Plan ]

   * reproducer is a livefs build of the ubuntu-cpc project for jammy
  riscv64 using the cloudware livefs build. The build will fail in the
  following way:

  ```
  + cp livecd.ubuntu-cpc.disk-uefi.manifest /build/livecd.ubuntu-cpc.qcow.manifest
  cp: cannot stat 'livecd.ubuntu-cpc.disk-uefi.manifest': No such file or directory
  + Echo_error config/hooks/021-qcow2-image.binary failed (exit non-zero). You should check for errors.
  ```

  [ Where problems could occur ]

   * the risk is that there is some subarch outside of those specified
  in the if-branch for which the early return is necessary. I don't have
  any indication that there is, but my information could very well be
  incomplete.

  [ Other Info ]

   * This appears to be isolated to jammy only, as we don't build qcow
  images for riscv in focal, and the hook was changed significantly in
  noble. Therefore this change should not need to be in other livecd-
  rootfs branches.

  1. https://code.launchpad.net/~codyshepherd/livecd-rootfs/+git/livecd-
  rootfs/+merge/475962

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2086455/+subscriptions