[Bug 2091425] Re: iptables-netflow-dkms FTBS in Noble with linux-6.11-hwe kernel

[Timo Aaltonen]

Hello Massimiliano, or anyone else affected,

Accepted iptables-netflow into noble-proposed. The package will build
now and be available at https://launchpad.net/ubuntu/+source/iptables-
netflow/2.6-6ubuntu2.1 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
noble to verification-done-noble. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-noble. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: iptables-netflow (Ubuntu Noble)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-noble

** Changed in: iptables-netflow (Ubuntu)
       Status: In Progress => Invalid

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2091425

Title:
  iptables-netflow-dkms FTBS in Noble with linux-6.11-hwe kernel

Status in iptables-netflow package in Ubuntu:
  Invalid
Status in iptables-netflow source package in Noble:
  Fix Committed

Bug description:
  [ Impact ]

  iptables-netflow-dkms does not compile from source in Noble with
  kernel 6.11:

  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c: At top level:
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1807:35: error: initialization of ‘int (*)(const struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(const struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} from incompatible pointer type ‘int (*)(struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} [-Werror=incompatible-pointer-types]
   1807 |                 .proc_handler   = &hsize_procctl,
        |                                   ^
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1807:35: note: (near initialization for ‘netflow_sysctl_table[3].proc_handler’)
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1813:35: error: initialization of ‘int (*)(const struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(const struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} from incompatible pointer type ‘int (*)(struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} [-Werror=incompatible-pointer-types]
   1813 |                 .proc_handler   = &sndbuf_procctl,
        |                                   ^
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1813:35: note: (near initialization for ‘netflow_sysctl_table[4].proc_handler’)
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1820:35: error: initialization of ‘int (*)(const struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(const struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} from incompatible pointer type ‘int (*)(struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} [-Werror=incompatible-pointer-types]
   1820 |                 .proc_handler   = &destination_procctl,
        |                                   ^
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1820:35: note: (near initialization for ‘netflow_sysctl_table[5].proc_handler’)
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1842:35: error: initialization of ‘int (*)(const struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(const struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} from incompatible pointer type ‘int (*)(struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} [-Werror=incompatible-pointer-types]
   1842 |                 .proc_handler   = &flush_procctl,
        |                                   ^
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1842:35: note: (near initialization for ‘netflow_sysctl_table[7].proc_handler’)
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1848:35: error: initialization of ‘int (*)(const struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(const struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} from incompatible pointer type ‘int (*)(struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} [-Werror=incompatible-pointer-types]
   1848 |                 .proc_handler   = &protocol_procctl,
        |                                   ^
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1848:35: note: (near initialization for ‘netflow_sysctl_table[8].proc_handler’)
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1870:35: error: initialization of ‘int (*)(const struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(const struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} from incompatible pointer type ‘int (*)(struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} [-Werror=incompatible-pointer-types]
   1870 |                 .proc_handler   = &promisc_procctl,
        |                                   ^
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1870:35: note: (near initialization for ‘netflow_sysctl_table[11].proc_handler’)
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1879:35: error: initialization of ‘int (*)(const struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(const struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} from incompatible pointer type ‘int (*)(struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} [-Werror=incompatible-pointer-types]
   1879 |                 .proc_handler   = &sampler_procctl,
        |                                   ^
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1879:35: note: (near initialization for ‘netflow_sysctl_table[12].proc_handler’)
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1897:35: error: initialization of ‘int (*)(const struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(const struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} from incompatible pointer type ‘int (*)(struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} [-Werror=incompatible-pointer-types]
   1897 |                 .proc_handler   = &snmp_procctl,
        |                                   ^
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1897:35: note: (near initialization for ‘netflow_sysctl_table[14].proc_handler’)
  /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1905:35: error: initialization of ‘int (*)(const struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(const struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} from incompatible pointer type ‘int (*)(struct ctl_table *, int,  void *, size_t *, loff_t *)’ {aka ‘int (*)(struct ctl_table *, int,  void *, long unsigned int *, long long int *)’} [-Werror=incompatible-pointer-types]
   1905 |                 .proc_handler   = &natevents_procctl,
        |                                   ^

  [ Test case ]

  Install the latest linux-6.11 kernel on Noble:

  $ sudo add-apt-repository ppa:canonical-kernel-team/ppa
  $ sudo apt update
  $ sudo apt install linux-image-6.11.0-12-generic \
                     linux-modules-6.11.0-12-generic \
                     linux-modules-extra-6.11.0-12-generic \
                     linux-headers-6.11.0-12-generic

  Install iptables-netflow-dkms:

  $ sudo apt install iptables-netflow-dkms

  Load the module:

  $ sudo modprobe ipt_NETFLOW

  The same procedure should be repeated on linux-6.8 to test for
  possible regressions.

  [ Fix ]

  Patch the code to properly support the new linux 6.11 ABI.

  [ Regression potential]

  We may experience networking-related regressions in systems that are
  using the iptables-netflow-dkms module and that are using a kernel >=
  6.11.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iptables-netflow/+bug/2091425/+subscriptions