[Bug 2084776] Re: [needs-packaging] pwl-pc-services: Support for Palcom Wireless WWAN modules

[Dave Jones]

I've gone through the updated version of the package in @vpa1977's PPA
and it looks like all the points raised in the first review have now
been addressed. I *would* be happy to sponsor it at this point, but for
one thing that's worrying me: the maintainer scripts.

The preinst/postrm script unconditionally removes
"/etc/systemd/system/ModemManager.service.d/pwl-mm-suspend-resume-
options.conf". I know this was suggested by the first review, but here's
why this makes me nervous:

Firstly, this package is a new package. It cannot previously have
existed on the user's machine, so if it's removing a file it's one
necessarily either not owned at all, or owned by another package. Does
this indicate a potential conflict with another package? Should this
only happen on certain versions of something else?

Secondly, the removal happens on *every* invocation of the maintscripts,
*even those involved in error recovery*. In other words, if the user
goes to install this package and something goes wrong, preinst will
potentially be called with abort-install (or abort-upgrade with future
versions), and will remove the file even though the package
install/upgrade is in the process of being aborted.

Normally, dpkg-maintscript-helper would be the way to "properly" handle
removal of extraneous conffiles. However, that won't work here because
the file in question cannot be owned by this packaage (and dpkg-
maintscript-helper won't operate on files not owned by the package being
installed / upgraded).

What I'd like to see to resolve this:

1. An (potentially brief) explanation of why this file needs removal,
especially considering it can't be a file owned by this package

2. A consideration of a non-destructive means; could it just be renamed?

3. If it can't just be renamed, a consideration of what should be done
in the abort-install/upgrade case

Other than that I can't see any other issues with this, and if the above
can be resolved, I'd be happy to sponsor this for upload. In the
meantime, I'll remove ubuntu-sponsors pending resolution -- please do
re-subscribe ubuntu-sponsors when the above point is addressed.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2084776

Title:
  [needs-packaging] pwl-pc-services: Support for Palcom Wireless WWAN
  modules

Status in OEM Priority Project:
  In Progress
Status in Ubuntu:
  In Progress

Bug description:
  Version: 4.2.1
  URL: https://github.com/palcomwireless/linux_pkgs
  License: GPL-2, Apache-2.0, BSD-3-Clause
  Programming Lang: C
  Description: Support for Palcom Wireless WWAN modules

  This package provides functionality and maintenance for Palcom Wireless WWAN modules.
  The package splits into the following services:
  - pwl-core-service
  - pwl-fwupdate-service
  - pwl-madpt-service
  - pwl-pref-service
  - pwl-unlock-service
  - pwl-test-quick-suspend-resume

  The package "pwl-unlock-service" is a binary-only file for FCC Unlock
  procedure, and will be used by ModemManager:
  https://modemmanager.org/docs/modemmanager/fcc-unlock/

  The packaging will include modaliases, which is not available in
  Debian packaging.

  This package will be uploaded to multiverse due to non dfsg-free
  contents.

  [Test plan]
  0. Verify the service on platform with Dell DW5826e USB\VID_413C&PID_8217 and valid sim
  FCC unlock
  1. Boot into Ubuntu
  2. Check if the WWAN can camp to network successfully
  3. Check the boot log by $ journalctl -b | grep pwl_unlock
     Should find below message:
  pwl_unlock[2865]: [2865] start
  pwl_unlock[2865]: Device type usb
  pwl_unlock[2865]: [2865] Host verify pass
  pwl_unlock[2865]: [2865] Module verify pass
  pwl_unlock[2865]: MBIM Device init
  pwl_unlock[2865]: MBIM Device new cb
  pwl_unlock[2865]: MBIM Device open
  pwl_unlock[2865]: MBIM Device /dev/cdc-wdm0 opened.
  pwl_unlock[2865]: [2865] mbim device ready
  pwl_unlock[2865]: [2865] FCC Unlock encrypt checking
  pwl_unlock[2865]: [2865] FCC Unlock cmd missing echo
  pwl_unlock[2865]: [2865] FCC Unlock encrypt checked
  pwl_unlock[2865]: [2865] FCC Unlock data prepared
  pwl_unlock[2865]: [2865] FCC Unlock decrypt info prepared
  pwl_unlock[2865]: [2865] FCC Unlock info prepare completed
  pwl_unlock[2865]: [2865] FCC Unlock ready for challenge
  pwl_unlock[2865]: [2865] Challenge pass
  pwl_unlock[2865]: [2865] Module functionality enable OK
  pwl_unlock[2865]: MBIM Device deinit
  pwl_unlock[2865]: MBIM Device close
  pwl_unlock[2865]: MBIM Device close cb
  pwl_unlock[2865]: [2865] exit

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/2084776/+subscriptions