[Bug 2054391] Re: Fix CPU thermal sensors enumeration

[Lucas Kanashiro]

Thanks for the patch @Kai-Heng! I took a look and in general it looks
good, but I'd like to ask you to add some DEP-3 headers [1] to your
patch, that will give us (packagers) more context when revisiting this
package for whatever reason.

Now a personal opinion, I like when the patch file name is listed in the
changelog entry ("* d/p/0016-Fixed-enumeration-of-cpu-thermal-
sensors.patch: <what_this_is_fixing>"). It makes a direct link between
the change listed there and the file actually fixing it.

Once you address my first comment at least (the second one is not
mandatory), please subscribe ~ubuntu-sponsors again (I am unsubscribing
it now).

[1] https://dep-team.pages.debian.net/deps/dep3/

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2054391

Title:
  Fix  CPU thermal sensors enumeration

Status in HWE Next:
  New
Status in thermald package in Ubuntu:
  Fix Released
Status in thermald source package in Jammy:
  Confirmed

Bug description:
  [Impact]
  Some CPU sensors are not enumerated, this can make thermald deviates from the correct behavior of the CPU TDP.

  [Fix]
  Traverse all sensors under hwmon sysfs directory to make sure everything is enumerated.

  [Test]
  Check the output of thermald. Once the fix is in place, thermal zones that are previously omitted now shows up:
  [INFO]Zone 1: AMBF, Active:1 Bind:1 Sensor_cnt:1

  [Where problems could occur]
  Since the new logic traverse the whole hwmon sysfs, the startup time can take slightly longer.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hwe-next/+bug/2054391/+subscriptions