[Bug 1892558] Re: [SRU] binhex always segfaults

[Sergio Durigan Junior]

Thank you for the patch.

Uploaded to Focal.

** Changed in: macutils (Ubuntu Focal)
       Status: Confirmed => In Progress

** Changed in: macutils (Ubuntu Focal)
     Assignee: (unassigned) => Sudip Mukherjee (sudipmuk)

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1892558

Title:
  [SRU] binhex always segfaults

Status in macutils package in Ubuntu:
  Fix Released
Status in macutils source package in Focal:
  In Progress

Bug description:
  [ Impact ]

  some of the binaries provided by macutils are completely unusable as they will immediately segfault as soon as they are executed.
  The impacted binaries are:
  binhex
  tomac
  frommac

  This is because the relevant header file was not included and so as as
  result the compiler assumed the functions return an integer.

  [ Test Plan ]

  1. Install macutils
  2. Execute all the binaries provided by macutils for a basic sanity test

  binhex -H
  frommac -H
  hexbin -H
  macsave -H
  macstream -H
  macunpack -H
  tomac -H

  If the package is not fixed then binhex, tomac and frommac will result in segfault.
   

  [ Where problems could occur ]

  There is no change in code, only the relevant header file has been
  included. And, so there are minimum chances of a regression. The
  change has been part of Debian and also Jammy onwards and there has
  been no regression reported.

  [ Other Info ]

  The testplan only does a basic sanity test. Ideally a macutils user
  should test and confirm that everything is working as expected.

  [ Original Bug Description ]

  Steps to reproduce:

  binhex -H

  Expected result: binhex prints help information

  Actual result: binhex crashes with SIGSEGV

  Comments: binhex doesn't only crash with the -H flag, it crashes with
  any flag. It appears to crash in the main() function before any
  argument handling actually happens.

  Version is 2.0b3-16build1.

  ProblemType: Bug
  DistroRelease: Ubuntu 18.04
  Package: macutils 2.0b3-16build1
  ProcVersionSignature: Ubuntu 5.4.0-42.46~18.04.1-generic 5.4.44
  Uname: Linux 5.4.0-42-generic x86_64
  ApportVersion: 2.20.9-0ubuntu7.16
  Architecture: amd64
  CurrentDesktop: KDE
  Date: Fri Aug 21 20:57:56 2020
  Dependencies:
   gcc-8-base 8.4.0-1ubuntu1~18.04
   libc6 2.27-3ubuntu1.2
   libgcc1 1:8.4.0-1ubuntu1~18.04
  InstallationDate: Installed on 2020-02-01 (202 days ago)
  InstallationMedia: Ubuntu 18.04.2 LTS "Bionic Beaver" - Release amd64 (20190210)
  SourcePackage: macutils
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/macutils/+bug/1892558/+subscriptions