[Merge] ~adrien-n/ubuntu/+source/dpkg:ubuntu/devel into ubuntu/+source/dpkg:ubuntu/devel

[git-ubuntu bot]

You have been requested to review the proposed merge of ~adrien-n/ubuntu/+source/dpkg:ubuntu/devel into ubuntu/+source/dpkg:ubuntu/devel.

For more details, see:
https://code.launchpad.net/~adrien-n/ubuntu/+source/dpkg/+git/dpkg/+merge/456181

I'm marking this as needing review because the code is ready but the question as to whether we should go this way seems to be still open.

Basically, -fstack-clash-protection doesn't work or doesn't work well enough on armhf. It got enabled only 2 or 3 weeks ago through a change in debian and we've had at least 3 autopkgtest failures already even though this is a less active period with the canonical sprints and thanksgiving. Other distros don't enable it (especially fedora/RH which enabled it on other arches years ago and state it's not fit on armhf). There are also failured in Debian where there's less consensus the option is broken on armhf (at least two FTBFS reported there).

Overall I think the safer approach is to disable it for now on armhf because it will only prevent more and more migrations and may result in FTBFS too. It seems better to disable it, take time to analyze the situation without the pressure of stuck migrations or FTBFS, and re-enable, possibly rebuilding everything.

On that last note, I don't think we really noticed this new flag and planned to rebuild everything with it. That's probably something to discuss briefly at least.

Tested on PPA: https://launchpad.net/~adrien-n/+archive/ubuntu/noble-no-fstack-clash-protection (versions don't have ~ppaX appended)
Rebuilt dpkg. Then rebuild gnutls, libarchive and libxml2. Mate Kukri confirmed all three packages were causing issues before and this rebuild made the issues go away.
I also looked at the build logs: -fstack-clash-protection is still present for amd64 and arm64 but is removed for armhf. It wasn't present for ppc64al and s390x, and it still isn't.

-- 
Your team Ubuntu Sponsors is requested to review the proposed merge of ~adrien-n/ubuntu/+source/dpkg:ubuntu/devel into ubuntu/+source/dpkg:ubuntu/devel.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1716 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-sponsors/attachments/20231123/86eda6b9/attachment.diff>