[Bug 2026589] Re: tp-smapi DKMS FTBFS wrt Linux 6.4

[Dave Jones]

The concerns about a test case for SRU need addressing, but the
suggested method of using the kernel team's PPA looks reasonable.

Unsubscribing ubuntu-sponsors until this is addressed; please re-
subscribe when the test case is updated to include instructions that
verify the patch under jammy with a 6.4 kernel (it wouldn't hurt to
check that it definitely doesn't affect the current 6.2 HWE kernel
either).

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2026589

Title:
  tp-smapi DKMS FTBFS wrt Linux 6.4

Status in tp-smapi package in Ubuntu:
  Fix Released
Status in tp-smapi source package in Jammy:
  Triaged

Bug description:
  [Impact]

  ...
  /var/lib/dkms/tp_smapi/0.43/build/thinkpad_ec.c:94:42: error: macro "DEFINE_SEMAPHORE" requires 2 arguments, but only 1 given
     94 | static DEFINE_SEMAPHORE(thinkpad_ec_mutex);
        |                                          ^
  ...

  [Fix]

  Apply the attached patch.

  [How to test]

  Install the patch package (and make sure it builds).

  [Regression potential]

  Low, the buildifx is an upstream cherrypick and it's conditionally
  compiled only if Linux >= 6.4.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/tp-smapi/+bug/2026589/+subscriptions