[Bug 1991909] Re: [SRU] ladvd FTBFS: error: ‘MAXPATHLEN’ undeclared

[Paride Legovini]

Hello and thanks for preparing the upload. A couple of comments:

* The quilt patch is not excellent. It includes changes that were not
part of the upstream commit [1] that fixes the FTBFS. The changes are
not harmful but they make the patch "dirty".

* The dep-3 headers are not fully correct. The patch comes from
upstream, so we should have "Origin: upstream, <link>", and not Applied-
Upstream.

I see that these issue are directly inherit from Debian (1.1.2-2). From
one side keeping the patch identical to what we have in the Ubuntu devel
release (and Debian) is nice, but I think the SRU team will prefer a
clean patch only touching what's necessary.

Now one comment on the d/changelog entry you added for this change. You
mention that the patch is a "backport", which makes me think that you
somehow adapted the Debian patch, while this is not the case, it is
taken as-is. Please consider rewording (perhaps using dep3changelog).

If you agree with these comments, could you please update your debdiff
accordingly?

Also please note that the upload will likely be staged [2], as it is low
priority.

Thanks!

[1] https://github.com/sspans/ladvd/commit/763358ea4a22795b616410fcba8ca182cb97a08e
[2] https://wiki.ubuntu.com/StableReleaseUpdates#Staging_an_upload

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1991909

Title:
  [SRU] ladvd FTBFS: error: ‘MAXPATHLEN’ undeclared

Status in ladvd package in Ubuntu:
  New
Status in ladvd package in Debian:
  Fix Released

Bug description:
  [ Impact ]

  ladvd fails to build in Jammy.

  [ Test Plan ]

  Confirm that ladvd builds.
  Execute ladvd in Jammy to confirm it starts runnning.

  But for anyone testing, these are the commands for some basic testing to see ladvd is running.
  ladvd -vvvvv -f -a

  [ Where problems could occur ]

  The patch is backported from Debian which is also an upstream fix.
  The fix (apart from the white-space changes) is only adding header file to the source code to fix the ftbfs.
  So, it should not change the behaviour and has little chance of regressing the user behaviour.

  [ Other Info ]

   The problem exists in 1.1.2-1 and has been fixed by Debian with the version 1.1.2-2.
   It has been updated on Ubuntu Lunar, Mantic and Noble. But Jammy still has the problem and the ftbfs can be seen.

  
  Original Bug Description:

  
  libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wformat -Wformat-security -DPIE -D_FORTIFY_SOURCE=2 --param ssp-buffer-size=4 -fstack-protector -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DLIBBSD_OVERLAY -isystem /usr/include/bsd -MT util.lo -MD -MP -MF .deps/util.Tpo -c ../../src/util.c  -fPIC -DPIC -o .libs/util.o
  In file included from ../../src/common.h:40,
                   from ../../src/util.c:20:
  /usr/include/bsd/vis.h:107:2: warning: #warning "NetBSD added incompatible strnvis() and strnunvis(), please see <bsd/vis.h> for more detils." [-Wcpp]
    107 | #warning "NetBSD added incompatible strnvis() and strnunvis(), please see <bsd/vis.h> for more detils."
        |  ^~~~~~~
  ../../src/util.c: In function ‘my_chroot’:
  ../../src/util.c:151:20: error: ‘MAXPATHLEN’ undeclared (first use in this function)
    151 |     char component[MAXPATHLEN];
        |                    ^~~~~~~~~~
  ../../src/util.c:151:20: note: each undeclared identifier is reported only once for each function it appears in
  ../../src/util.c:151:10: warning: unused variable ‘component’ [-Wunused-variable]
    151 |     char component[MAXPATHLEN];
        |          ^~~~~~~~~
  make[3]: *** [Makefile:599: util.lo] Error 1
  make[3]: Leaving directory '/<<PKGBUILDDIR>>/build/src'

  Full log: https://launchpadlibrarian.net/625443175/buildlog_ubuntu-
  kinetic-amd64.ladvd_1.1.2-1build1_BUILDING.txt.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ladvd/+bug/1991909/+subscriptions