[Bug 2019147] Please test proposed package

[Robie Basak]

Hello Talha, or anyone else affected,

Accepted freeipmi into lunar-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/freeipmi/1.6.10-1ubuntu0.1 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
lunar to verification-done-lunar. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-lunar. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2019147

Title:
  [SRU] Add Xilinx support patch to enable latest Xilinx tools

Status in freeipmi package in Ubuntu:
  Fix Released
Status in freeipmi source package in Jammy:
  Fix Committed
Status in freeipmi source package in Kinetic:
  Fix Committed
Status in freeipmi source package in Lunar:
  Fix Committed

Bug description:
  [ Impact ]

   * It prevents the users of Xilinx boards to use latest versions of
  Xilinx SDK tools.

   * Since Ubuntu is officially supports  Xilinx Kria boards, we need to
  add Xilinx OEM support into freeipmi to enable latest Xilinx SDK tools
  on jammy, kinetic and lunar.

  [ Test Plan ]

   * Xilinx OEM data parsing is not supported on current version of
  freeipmi. So when you try to run `sudo ipmi-fru --fru-file
  /sys/bus/i2c/devices/1-0050/eeprom --interpret-oem-data` on a Xilinx
  Kria board you wont be able to get the oem specific data.

   * When the patch is applied, you must be able to see the Xilinx OEM data parsed successfully as in following output.
  ```
  ubuntu at kria:~$ sudo ipmi-fru --fru-file /sys/bus/i2c/devices/1-0050/eeprom --interpret-oem-data
  FRU Inventory From File: /sys/bus/i2c/devices/1-0050/eeprom

  FRU Board Manufacturing Date/Time: 12/20/22 - 12:51:00
  FRU Board Manufacturer: XILINX
  FRU Board Product Name: SMK-K24-XCL2G
  FRU Board Serial Number: 51281A22C82S
  FRU Board Part Number: 05128-01
  FRU FRU File ID: 00h
  FRU Board Custom Info: A
  FRU Board Custom Info: 10h EEh 00h 00h 00h 00h 00h 00h
  FRU Board Custom Info: 66h 27h 20h 4Bh 4Eh 48h EFh 9Bh 35h 47h 1Ah 02h A2h 63h 66h B5h

  FRU DC Load Output Number: 1
  FRU DC Load Nominal Voltage: 5000 mV
  FRU DC Load Spec'd Minimum Voltage: 4500 mV
  FRU DC Load Spec'd Maximum Voltage: 5500 mV
  FRU DC Load Spec'd Ripple and Noise pk-pk: 100 mV
  FRU DC Load Minimum Current Load: 0 mA
  FRU DC Load Maximum Current Load: 2000 mA

  FRU OEM Manufacturer ID: Xilinx, Inc. (10DAh)
  FRU OEM MAC Version: DUT - MAC (31h)
  FRU OEM MAC ID 0: 00:0a:35:18:76:08

  FRU OEM Manufacturer ID: Xilinx, Inc. (10DAh)
  FRU OEM Memory: QSPI:512Mb
  FRU OEM Memory: eMMC:32GB
  FRU OEM Memory: PSDDR4:2GB
  FRU OEM Memory: PLDDR4:None
  ```

  [ Where problems could occur ]

   * Since the change is only on OEM data parsing part of `ipmi-fru`
  tool it could only break `--interpret-oem-data` option for Xilinx
  boards.

   * This change must not introduce a regression since the Xilinx OEM
  support will be newly added via this patch.

   * Plus, patch is already in stable branch of the upstream project so
  it is accepted by the maintainer as a stable patch.

   * [racb] The common code being changed looks for a new
  manufacturer_id of IPMI_IANA_ENTERPRISE_ID_XILINX (defined to be 4314)
  and follows a different path in that case, including a (slightly)
  early exit that skips the output of generic hex data. Presumably this
  deliberately changes behaviour to provide richer output. Anyone
  relying on the previous hex output behaviour will be broken, but this
  seems deliberate and acceptable as part of hardware enablement.

   * [racb] If some other board identifies the same way, then behaviour
  on that board will chage, too.

  [ Other Info ]

   * This patch request is created after evaluating LP #2015825.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/2019147/+subscriptions