[Bug 2019147] Re: [SRU] Add Xilinx support patch to enable latest Xilinx tools

[Athos Ribeiro]

Hi Talha, thanks for addressing the requested changes.

The version field still needs fixing. Check the examples in
https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging.
The idea here is to avoid upgrade path issues. For instance, by keeping
the same versions in jammy and kinetic, a user upgrading from jammy to
kinetic would not get his freeipmi package upgraded since the version in
the new series would not be greater.

You want to change those string to the following versions:

lunar: 1.6.10-1ubuntu0.1
kinetic: 1.6.9-2ubuntu0.22.10.1
jammy: 1.6.9-2ubuntu0.22.04.1

It would also be nice to adjust the changelog message to set it to an imperative form to match other messages in the changelog.
 
* d/p/add-initial-support-for-xilinx.patch: support Xilinx (LP: #2015825)

Still for the changelog, I just realized that the reference in there
points to a different (private) bug. Instead, you want to refer to this
bug, with the SRU template.

* d/p/add-initial-support-for-xilinx.patch: support Xilinx (LP:
#2019147)

In https://wiki.ubuntu.com/StableReleaseUpdates, you will find:

"Also make sure that [...] There is a reference to the SRU bug number in
the changelog, using the 'LP: #NNNNNN' convention. Only public bugs
should be referenced in the changelog."

Finally, you could have kept the commit message in the patch files,
which would add more context to the patches. Then, you could add the
remaining DE3 headers after that description. This is just a nitpick, no
need to change that though.

Overall, the changes LGTM.

I also pushed them to a PPA to ensure the builds are sane in all
supported platforms: https://launchpad.net/~athos-
ribeiro/+archive/ubuntu/freeipmi-xilinx/+packages.

Next time, it would be nice to do the same to show the sponsors you
checked those builds.

Thank you!

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2019147

Title:
  [SRU] Add Xilinx support patch to enable latest Xilinx tools

Status in freeipmi package in Ubuntu:
  Fix Released
Status in freeipmi source package in Jammy:
  Triaged
Status in freeipmi source package in Kinetic:
  Triaged
Status in freeipmi source package in Lunar:
  Triaged

Bug description:
  [ Impact ]

   * It prevents the users of Xilinx boards to use latest versions of
  Xilinx SDK tools.

   * Since Ubuntu is officially supports  Xilinx Kria boards, we need to
  add Xilinx OEM support into freeipmi to enable latest Xilinx SDK tools
  on jammy, kinetic and lunar.

  
  [ Test Plan ]

   * Xilinx OEM data parsing is not supported on current version of
  freeipmi. So when you try to run `sudo ipmi-fru --fru-file
  /sys/bus/i2c/devices/1-0050/eeprom --interpret-oem-data` on a Xilinx
  Kria board you wont be able to get the oem specific data.

   * When the patch is applied, you must be able to see the Xilinx OEM data parsed successfully as in following output.
  ```
  ubuntu at kria:~$ sudo ipmi-fru --fru-file /sys/bus/i2c/devices/1-0050/eeprom --interpret-oem-data
  FRU Inventory From File: /sys/bus/i2c/devices/1-0050/eeprom

  FRU Board Manufacturing Date/Time: 12/20/22 - 12:51:00
  FRU Board Manufacturer: XILINX
  FRU Board Product Name: SMK-K24-XCL2G
  FRU Board Serial Number: 51281A22C82S
  FRU Board Part Number: 05128-01
  FRU FRU File ID: 00h
  FRU Board Custom Info: A
  FRU Board Custom Info: 10h EEh 00h 00h 00h 00h 00h 00h
  FRU Board Custom Info: 66h 27h 20h 4Bh 4Eh 48h EFh 9Bh 35h 47h 1Ah 02h A2h 63h 66h B5h

  FRU DC Load Output Number: 1
  FRU DC Load Nominal Voltage: 5000 mV
  FRU DC Load Spec'd Minimum Voltage: 4500 mV
  FRU DC Load Spec'd Maximum Voltage: 5500 mV
  FRU DC Load Spec'd Ripple and Noise pk-pk: 100 mV
  FRU DC Load Minimum Current Load: 0 mA
  FRU DC Load Maximum Current Load: 2000 mA

  FRU OEM Manufacturer ID: Xilinx, Inc. (10DAh)
  FRU OEM MAC Version: DUT - MAC (31h)
  FRU OEM MAC ID 0: 00:0a:35:18:76:08

  FRU OEM Manufacturer ID: Xilinx, Inc. (10DAh)
  FRU OEM Memory: QSPI:512Mb
  FRU OEM Memory: eMMC:32GB
  FRU OEM Memory: PSDDR4:2GB
  FRU OEM Memory: PLDDR4:None
  ```

  [ Where problems could occur ]

   * Since the change is only on OEM data parsing part of `ipmi-fru`
  tool it could only break `--interpret-oem-data` option for Xilinx
  boards.

   * This change must not introduce a regression since the Xilinx OEM
  support will be newly added via this patch.

   * Plus, patch is already in stable branch of the upstream project so
  it is accepted by the maintainer as a stable patch.

  
  [ Other Info ]
   
   * This patch request is created after evaluating LP #2015825.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/2019147/+subscriptions