[Bug 1983451] Re: [fwupd][SRU] Hide inhibited usb4 device in dell-dock plugin

[Andreas Hasenack]

Hello hugh, or anyone else affected,

Accepted fwupd into jammy-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/fwupd/1.7.9-1~22.04.3
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
jammy to verification-done-jammy. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-jammy. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: fwupd (Ubuntu Jammy)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-jammy

** Changed in: fwupd (Ubuntu Focal)
       Status: In Progress => Fix Committed

** Tags added: verification-needed-focal

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1983451

Title:
  [fwupd][SRU] Hide inhibited usb4 device in dell-dock plugin

Status in OEM Priority Project:
  Confirmed
Status in OEM Priority Project focal series:
  Confirmed
Status in fwupd package in Ubuntu:
  Fix Released
Status in fwupd source package in Focal:
  Fix Committed
Status in fwupd source package in Jammy:
  Fix Committed
Status in fwupd source package in Kinetic:
  Fix Released

Bug description:
  In fwupd mechanism, a device might be probed by multiple plugins, so
  an "inhibited flag" might be applied to prevent it been probed several
  times.

  An "Update Error" message will show up once this flag has been applied
  [0], and this will confuse some users to let they think the firmware
  upgrade process failed , in the purpose of improving the user
  experience, a patch has been merged to upstream to hide the inhibited
  usb4 device[1].

  [Impact]
   * A new flag "hidden" has been added in the inhibited code snippet, once the device enumeration found this flag, it will not show it.
   * Since this misleading message has be hidden, the users won't be confused on the inhibited message.

  [Test Plan]
   * Prepare a dell-dock wd22tb4.

   * Prepare one pc or laptop with thunderbolt interface on it.

   * Before(include) fwupd upstream version 1.8.2 or Ubuntu version
  1.7.5-3, a "waning message"[0] will be observed on the inhibited
  device via the command "fwupdmgr get-devices".

   * Once this patch has been applied, the inhibited device will be
  hidden.

  [Where problems could occur]
   * The only problem might occur is once someone misuses this flag "hidden" when they use this device_inhibit function, then the devices will be hidden.
   * But after double confirm, I __do not__ see someone else has applied this flag on their plugin.

  [0] https://github.com/fwupd/fwupd/tree/main/plugins/dell-dock#update-behavior
  [1] https://github.com/fwupd/fwupd/commit/4bf53196fc1198a0688b49bcd16cd0126823f434

  For other risk and test plan, please check lp:1982103

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1983451/+subscriptions