[Bug 1983451] Re: [fwupd][SRU] Hide inhibited usb4 device in dell-dock plugin

[Lukas Märdian]

Thank you! With Mario's comment in #33 I feel more confident in
sponsoring this into Jammy and Focal.

The patches match the upstream commits (except some whitespace: tab vs spaces):
* https://github.com/fwupd/fwupd/commit/6b5d933e99dce7f2bf2b771176001191a3bab644
* https://github.com/fwupd/fwupd/commit/4bf53196fc1198a0688b49bcd16cd0126823f434

Please consider adding DEP-3 headers next time, so it's easier to
understand the upstream status of a patch: https://dep-
team.pages.debian.net/deps/dep3/


I've modified the SRU's version sting to match the schema that was used for previous SRUs, which we have in jammy-proposed and focal-proposed currently and adopt the .symbols file accordingly, to provide the new symbol:

```diff
diff --git a/debian/changelog b/debian/changelog
index 8912feb52..eccdd5c88 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,4 @@
-fwupd (1.7.9-1ubuntu1~22.04.2) jammy; urgency=medium
+fwupd (1.7.9-1~22.04.3) jammy; urgency=medium
 
   * Hide inhibited usb4 device in dell-dock plugin (LP: #1983451)
     d/p/0001-Do-not-show-unconnected-or-unreachable-devices-in-th.patch
diff --git a/debian/libfwupdplugin5.symbols b/debian/libfwupdplugin5.symbols
index 961cdef81..9235b9dcd 100644
--- a/debian/libfwupdplugin5.symbols
+++ b/debian/libfwupdplugin5.symbols
@@ -57,6 +57,7 @@ libfwupdplugin.so.5 libfwupdplugin5 #MINVER#
  LIBFWUPDPLUGIN_1.7.3 at LIBFWUPDPLUGIN_1.7.3 1.7.3
  LIBFWUPDPLUGIN_1.7.4 at LIBFWUPDPLUGIN_1.7.4 1.7.4
  LIBFWUPDPLUGIN_1.7.6 at LIBFWUPDPLUGIN_1.7.6 1.7.9
+ LIBFWUPDPLUGIN_1.8.0 at LIBFWUPDPLUGIN_1.8.0 1.7.9-1~22.04.3~
  fu_archive_firmware_get_type at LIBFWUPDPLUGIN_1.7.3 1.7.3
  fu_archive_firmware_new at LIBFWUPDPLUGIN_1.7.3 1.7.3
  fu_archive_get_type at LIBFWUPDPLUGIN_1.2.2 1.2.2
@@ -355,6 +356,7 @@ libfwupdplugin.so.5 libfwupdplugin5 #MINVER#
  fu_device_get_specialized_gtype at LIBFWUPDPLUGIN_1.3.3 1.3.3
  fu_device_get_type at LIBFWUPDPLUGIN_0.1.0 0.1.0
  fu_device_has_guid at LIBFWUPDPLUGIN_1.2.2 1.2.2
+ fu_device_has_inhibit at LIBFWUPDPLUGIN_1.8.0 1.7.9-1~22.04.3~
  fu_device_has_internal_flag at LIBFWUPDPLUGIN_1.5.5 1.5.5
  fu_device_has_parent_guid at LIBFWUPDPLUGIN_1.0.8 1.0.8
  fu_device_has_parent_physical_id at LIBFWUPDPLUGIN_1.6.2 1.6.2
```

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1983451

Title:
  [fwupd][SRU] Hide inhibited usb4 device in dell-dock plugin

Status in OEM Priority Project:
  Confirmed
Status in OEM Priority Project focal series:
  Confirmed
Status in fwupd package in Ubuntu:
  Fix Released
Status in fwupd source package in Focal:
  In Progress
Status in fwupd source package in Jammy:
  In Progress
Status in fwupd source package in Kinetic:
  Fix Released

Bug description:
  In fwupd mechanism, a device might be probed by multiple plugins, so
  an "inhibited flag" might be applied to prevent it been probed several
  times.

  An "Update Error" message will show up once this flag has been applied
  [0], and this will confuse some users to let they think the firmware
  upgrade process failed , in the purpose of improving the user
  experience, a patch has been merged to upstream to hide the inhibited
  usb4 device[1].

  [Impact]
   * A new flag "hidden" has been added in the inhibited code snippet, once the device enumeration found this flag, it will not show it.
   * Since this misleading message has be hidden, the users won't be confused on the inhibited message.

  [Test Plan]
   * Prepare a dell-dock wd22tb4.

   * Prepare one pc or laptop with thunderbolt interface on it.

   * Before(include) fwupd upstream version 1.8.2 or Ubuntu version
  1.7.5-3, a "waning message"[0] will be observed on the inhibited
  device via the command "fwupdmgr get-devices".

   * Once this patch has been applied, the inhibited device will be
  hidden.

  [Where problems could occur]
   * The only problem might occur is once someone misuses this flag "hidden" when they use this device_inhibit function, then the devices will be hidden.
   * But after double confirm, I __do not__ see someone else has applied this flag on their plugin.

  [0] https://github.com/fwupd/fwupd/tree/main/plugins/dell-dock#update-behavior
  [1] https://github.com/fwupd/fwupd/commit/4bf53196fc1198a0688b49bcd16cd0126823f434

  For other risk and test plan, please check lp:1982103

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1983451/+subscriptions