[Bug 1843708] [NEW] [SRU] Key-pair is not updated during the rebuild

[Launchpad Bug Tracker]

You have been subscribed to a public bug by Ubuntu Foundations Team Bug Bot (crichton):

[ Impact ]

 * See the original bug description below

[ Test Plan ]

 * See the original bug description below

[ Where problems could occur ]

 * See the original bug description below

[ Other Info ]
 
 * the fix 6a7a78a44 is already in stable/queens, but not in 17.0.13
 
 
Original Bug Description
===========

When we want to rebuild an instance and change the keypair we can specified it with :
openstack --os-compute-api-version 2.54  server rebuild --image "Debian 10" --key-name key1 instance1

This comes from this implementation :
https://review.opendev.org/#/c/379128/
https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/rebuild-keypair-reset.html

But when rebuilding the instance, Cloud-Init will set the key in authorized_keys from
http://169.254.169.254/openstack/latest/meta_data.json

And this meta_data.json uses the keys from instance_extra tables
But the keypair will be updated in the 'instances' table but not in the 'instance_extra' table.

So the keypair is not updated inside the VM

May be this is the function for saving the keypair, but the save() do nothing :
https://opendev.org/openstack/nova/src/branch/master/nova/objects/instance.py#L714

Steps to reproduce
==================

- Deploy a DevStack
- Boot an instance with keypair key1
- Rebuild it with key2
- A nova show will show the key_name key2, keypairs object in table instance_extra is not updated and you cannot connect with key2 to the instance

Expected result
===============
Connecte to the Vm with the new keypair added during the rebuild call

Actual result
=============
The keypair added during the rebuild call is not set in the VM

Environment
===========
I tested it on a Devstack from master and we have the behaviour.
NOVA : commit 5fa49cd0b8b6015aa61b4312b2ce1ae780c42c64

** Affects: cloud-archive
     Importance: Undecided
         Status: New

** Affects: cloud-archive/rocky
     Importance: Undecided
         Status: Won't Fix

** Affects: cloud-archive/stein
     Importance: Undecided
         Status: Fix Released

** Affects: cloud-archive/train
     Importance: Undecided
         Status: Fix Released

** Affects: cloud-archive/ussuri
     Importance: Undecided
         Status: Fix Released

** Affects: nova
     Importance: Undecided
     Assignee: Stephen Finucane (stephenfinucane)
         Status: Fix Released

** Affects: nova/queens
     Importance: Undecided
     Assignee: Stephen Finucane (stephenfinucane)
         Status: Fix Released

** Affects: nova/rocky
     Importance: Undecided
     Assignee: Stephen Finucane (stephenfinucane)
         Status: Fix Released

** Affects: nova/stein
     Importance: Undecided
     Assignee: Stephen Finucane (stephenfinucane)
         Status: Fix Released

** Affects: nova/train
     Importance: Undecided
         Status: Fix Released

** Affects: nova/ussuri
     Importance: Undecided
         Status: Fix Released

** Affects: nova (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: nova (Ubuntu Bionic)
     Importance: Undecided
         Status: New

** Affects: nova (Ubuntu Focal)
     Importance: Undecided
         Status: Fix Released


** Tags: keypairs patch rebuild sts sts-sru-needed
-- 
[SRU] Key-pair is not updated during the rebuild
https://bugs.launchpad.net/bugs/1843708
You received this bug notification because you are a member of Ubuntu Sponsors Team, which is subscribed to the bug report.