[Bug 2012410] Re: ivsc-driver module should not try to build when CONFIG_GPIOLIB_IRQCHIP is disabled

[You-Sheng Yang]

This depends on
https://bugs.launchpad.net/ubuntu/+source/dkms/+bug/2012612.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2012410

Title:
  ivsc-driver module should not try to build when CONFIG_GPIOLIB_IRQCHIP
  is disabled

Status in ivsc-driver package in Ubuntu:
  New
Status in ivsc-driver source package in Jammy:
  New
Status in ivsc-driver source package in Kinetic:
  New

Bug description:
  SRU justification:

  [Impact]

  This is encountered on linux kernel derivatives with fewer configuration options enabled.
  First time seen on jammy:linux-kvm-1029.

  During build, it fails with the following error:
  ...
  Building module:
  cleaning build area...
  make -j1 KERNELRELEASE=5.15.0-1030-kvm KERNELRELEASE=5.15.0-1030-kvm KERNEL_SRC=/lib/modules/5.15.0-1030-kvm/build......(bad exit status: 2)
  Error! Bad return status for module build on kernel: 5.15.0-1030-kvm (x86_64)
  Consult /var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/make.log for more information.
  E: ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1 failed to build for 5.15.0-1030-kvm
  ========== /var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/make.log ==========
  DKMS make.log for ivsc-driver-0~git202211241536.70d95269-0ubuntu0.22.04.1 for kernel 5.15.0-1030-kvm (x86_64)
  Wed Mar  8 23:41:46 UTC 2023
  make -C /lib/modules/5.15.0-1030-kvm/build M=/var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build modules
  make[1]: Entering directory '/usr/src/linux-headers-5.15.0-1030-kvm'
    CC [M]  /var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/drivers/mfd/ljca.o
    LD [M]  /var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/ljca.o
    CC [M]  /var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/drivers/spi/spi-ljca.o
    LD [M]  /var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/spi-ljca.o
    CC [M]  /var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/drivers/gpio/gpio-ljca.o
  /var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/drivers/gpio/gpio-ljca.c: In function ‘ljca_gpio_event_cb’:
  /var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/drivers/gpio/gpio-ljca.c:268:53: error: ‘struct gpio_chip’ has no member named ‘irq’
    268 |                 irq = irq_find_mapping(ljca_gpio->gc.irq.domain,
        |                                                     ^
  /var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/drivers/gpio/gpio-ljca.c: In function ‘ljca_gpio_probe’:
  /var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/drivers/gpio/gpio-ljca.c:441:30: error: ‘struct gpio_chip’ has no member named ‘irq’
    441 |         girq = &ljca_gpio->gc.irq;
        |                              ^
  make[2]: *** [scripts/Makefile.build:297: /var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/drivers/gpio/gpio-ljca.o] Error 1
  make[1]: *** [Makefile:1906: /var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build] Error 2
  make[1]: Leaving directory '/usr/src/linux-headers-5.15.0-1030-kvm'
  make: *** [Makefile:43: all] Error 2
  ====================
  ./ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/make.log
  autopkgtest [23:42:00]: test dkms-autopkgtest: -----------------------]
  autopkgtest [23:42:00]: test dkms-autopkgtest:  - - - - - - - - - - results - - - - - - - - - -
  dkms-autopkgtest     FAIL non-zero exit status 1
  autopkgtest [23:42:00]: @@@@@@@@@@@@@@@@@@@@ summary
  dkms-autopkgtest     FAIL non-zero exit status 1
  ====================
  ./ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/make.log
  autopkgtest [23:42:45]: test dkms-autopkgtest: -----------------------]
  autopkgtest [23:42:46]: test dkms-autopkgtest: - - - - - - - - - - results - - - - - - - - - -
  dkms-autopkgtest FAIL non-zero exit status 1
  autopkgtest [23:42:46]: @@@@@@@@@@@@@@@@@@@@ summary

  because CONFIG_GPIOLIB_IRQCHIP=n

  [Fix]
  Add a rule to avoid building ivsc-driver when CONFIG_GPIOLIB_IRQCHIP=n

  [Test Plan]
  Install a new version of jammy:linux-kvm (1029 for example).
  apt install ivsc-driver will fail as described above.
  After the fix, it will not be built at all.

  Once the package is in proposed, a new adt is triggered against
  proposed for jammy:linux-kvm.

  [Where problems could occur]
  Low possibility of new issues.

  [Note]
  This fix is not scalable in the sense that if configuration name changes, the module has to be changed as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ivsc-driver/+bug/2012410/+subscriptions