[Merge] ~danilogondolfo/ubuntu/+source/icdiff:autopkgtest_fix into ubuntu/+source/icdiff:ubuntu/devel
git-ubuntu bot
mp+439360 at code.launchpad.net
Wed Mar 22 02:25:50 UTC 2023
You have been requested to review the proposed merge of ~danilogondolfo/ubuntu/+source/icdiff:autopkgtest_fix into ubuntu/+source/icdiff:ubuntu/devel.
For more details, see:
https://code.launchpad.net/~danilogondolfo/ubuntu/+source/icdiff/+git/icdiff/+merge/439360
One of the tests sadly rely on the file descriptor number from a process substitution in the test script. In our environment, there are 2 extra FDs already allocated when the script starts, 63 and 62. The test expects to find /dev/fd/63 but finds /dev/fd/61.
This problem doesn't happen when the test is executed out of autopkgtest.
This solution is not great, it will close both existing FDs so when the process substitution happens it will get the expected FD. It still works when executed out of autopkgtest.
This problem apparently doesn't happen in the Debian's CI. But if I try running it on Debian locally it happens.
Alternatively I could refactor the test to not rely on the FD number.
--
Your team Ubuntu Sponsors Team is requested to review the proposed merge of ~danilogondolfo/ubuntu/+source/icdiff:autopkgtest_fix into ubuntu/+source/icdiff:ubuntu/devel.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3161 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-sponsors/attachments/20230322/9cd6b7d7/attachment-0001.diff>
More information about the Ubuntu-sponsors
mailing list