[Merge] ~holmanb/ubuntu/+source/isc-dhcp:ubuntu/devel into ubuntu/+source/isc-dhcp:ubuntu/devel

[git-ubuntu bot]

You have been requested to review the proposed merge of ~holmanb/ubuntu/+source/isc-dhcp:ubuntu/devel into ubuntu/+source/isc-dhcp:ubuntu/devel.

For more details, see:
https://code.launchpad.net/~holmanb/ubuntu/+source/isc-dhcp/+git/isc-dhcp/+merge/439186

Dhclient doesn't provide a mechanism for disabling hook scripts, which may provide undesirable system side effects. It does, however, allow the caller to define custom scripts. Therefore, one way to effectively disable hook scripts is to provide a no-op script, such as /bin/true. This MP allows dhclient to execute /bin/true such that default hook scripts may effectively be disabled.  

Before this change, note the "Permission denied" in the output:                                                                         
                                                                                
$ sudo dhclient -1 -v -lf /run/dhclient.lease -pf /run/dhclient.pid enp24s0 -sf /bin/true
Internet Systems Consortium DHCP Client 4.4.3-P1                                
Copyright 2004-2022 Internet Systems Consortium.                                
All rights reserved.                                                            
For info, please visit https://www.isc.org/software/dhcp/                       
                                                                                
execve (/bin/true, ...): Permission denied                                      
Listening on LPF/enp24s0/30:9c:23:e6:be:f0                                      
Sending on   LPF/enp24s0/30:9c:23:e6:be:f0                                      
Sending on   Socket/fallback                                                    
DHCPREQUEST for 192.168.1.145 on enp24s0 to 255.255.255.255 port 67             
DHCPACK of 192.168.1.145 from 192.168.1.1                                       
execve (/bin/true, ...): Permission denied                                      
bound to 192.168.1.145 -- renewal in 39752 seconds.                             
                                                                                

After this change, note the "Permission denied" is gone.

$ sudo dhclient -1 -v -lf /run/dhclient.lease -pf /run/dhclient.pid enp24s0 -sf /bin/true                                                                                                                          
Internet Systems Consortium DHCP Client 4.4.3-P1                                
Copyright 2004-2022 Internet Systems Consortium.                                
All rights reserved.                                                            
For info, please visit https://www.isc.org/software/dhcp/                       
                                                                                
Listening on LPF/enp24s0/30:9c:23:e6:be:f0                                      
Sending on   LPF/enp24s0/30:9c:23:e6:be:f0                                      
Sending on   Socket/fallback                                                    
xid: warning: no netdev with useable HWADDR found for seed's uniqueness enforcement
xid: rand init seed (0x646bc97f) built using gethostid                          
DHCPREQUEST for 192.168.1.145 on enp24s0 to 255.255.255.255 port 67 (xid=0x46eceb7d)
DHCPACK of 192.168.1.145 from 192.168.1.1 (xid=0x7debec46)                      
bound to 192.168.1.145 -- renewal in 39745 seconds.      

-- 
Your team Ubuntu Sponsors Team is requested to review the proposed merge of ~holmanb/ubuntu/+source/isc-dhcp:ubuntu/devel into ubuntu/+source/isc-dhcp:ubuntu/devel.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1172 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-sponsors/attachments/20230317/0262d867/attachment.diff>