[Merge] ~mitchdz/ubuntu/+source/multipath-tools:mitch/fix_update_fail into ubuntu/+source/multipath-tools:ubuntu/focal-devel

[Robie Basak]

Review: Needs Information

Thank you for working on this! Please see comment inline.

Diff comments:

> diff --git a/debian/multipath-tools.postinst b/debian/multipath-tools.postinst
> index fef2966..6d34a50 100644
> --- a/debian/multipath-tools.postinst
> +++ b/debian/multipath-tools.postinst
> @@ -17,6 +17,14 @@ set -e
>  # for details, see http://www.debian.org/doc/debian-policy/ or
>  # the debian-policy package
>  
> +# Previous versions installed init scripts, remove because we do not need
> +file_to_delete="/etc/init.d/multipath-tools"
> +
> +if [ -e "$file_to_delete" ]; then
> +    echo "Removing $file_to_delete"
> +    rm "$file_to_delete"
> +fi

Are you familiar with dpkg-maintscript-helper(1)? See also dh_installdeb(1) which will call it via debian/<package>.maintscript.

I would expect the removal to take place via the maintscript helper rm_conffile mechanism. If there's a reason that shouldn't be the case here, please could you explain?

I also wondered if this was done in Mantic, but don't see that in the Mantic MP linked from the linked bug. Does that also need fixing?

> +
>  RULE=/etc/udev/rules.d/multipath.rules
>  
>  case "$1" in


-- 
https://code.launchpad.net/~mitchdz/ubuntu/+source/multipath-tools/+git/multipath-tools/+merge/447587
Your team Ubuntu Sponsors is requested to review the proposed merge of ~mitchdz/ubuntu/+source/multipath-tools:mitch/fix_update_fail into ubuntu/+source/multipath-tools:ubuntu/focal-devel.